Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.0.0] - cloud.py drop CloudRetry.backoff (and by proxy AWSRetry.backoff) #1110

Closed
1 task done
tremble opened this issue Oct 5, 2022 · 1 comment · Fixed by #1135
Closed
1 task done

[6.0.0] - cloud.py drop CloudRetry.backoff (and by proxy AWSRetry.backoff) #1110

tremble opened this issue Oct 5, 2022 · 1 comment · Fixed by #1135
Labels
feature This issue/PR relates to a feature request module_utils module_utils needs_triage plugins plugin (any type)
Milestone
6.0.0

Comments

@tremble
Copy link
Contributor

tremble commented Oct 5, 2022

Summary

When CloudRetry was rewritten we deprecated CloudRetry.backoff (which does the same thing as CloudRetry.exponential_backoff but with different parameter names)

We originally said we'd remove it for 4.0.0, but hadn't cleaned up, so bumped the deprecation to 6.0.0

It is time to remove it.

Issue Type

Feature Idea

Component Name

plugins/module_utils/cloud.py

Additional Information

No response

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@tremble tremble added this to the 6.0.0 milestone Oct 5, 2022
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module_utils module_utils needs_triage plugins plugin (any type) labels Oct 5, 2022
@tremble tremble mentioned this issue Oct 7, 2022
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this issue Oct 10, 2022
@tremble
Remove deprecated CloudRetry.backoff (and AWSRetry.backoff) (#1135)
d732362 
Remove deprecated CloudRetry.backoff (and AWSRetry.backoff)

SUMMARY
Originally slated for removal in 4.0.0 and backed off to 6.0.0 in #951.  Now that we've branched stable-5 we can remove the deprecated decorator
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/cloud.py
ADDITIONAL INFORMATION
fixes: #1110

Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
@goneri
ec2_transit_gateway_IncorrectState: retry on IncorrectState (ansible-…
7acbee3 
…collections#1110)

* ec2_transit_gateway_IncorrectState: retry on IncorrectState

Do not immediately bail out in case of IncorrectState error. We now
instead wait and retry.

E.g: https://ddf1d621d7b816539203-e56a3e9170eb32404c2ff3e77b13356f.ssl.cf2.rackcdn.com/799/690df9c2d3f69323837542b96fa7318650fd5308/check/integration-community.aws-1/f30fb4f/job-output.txt
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
@goneri @abikouo
ec2_transit_gateway_IncorrectState: retry on IncorrectState (ansible-…
ff3080f 
…collections#1110)

* ec2_transit_gateway_IncorrectState: retry on IncorrectState

Do not immediately bail out in case of IncorrectState error. We now
instead wait and retry.

E.g: https://ddf1d621d7b816539203-e56a3e9170eb32404c2ff3e77b13356f.ssl.cf2.rackcdn.com/799/690df9c2d3f69323837542b96fa7318650fd5308/check/integration-community.aws-1/f30fb4f/job-output.txt
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Oct 24, 2023
@goneri
ec2_transit_gateway_IncorrectState: retry on IncorrectState (ansible-…
de08a9d 
…collections#1110)

* ec2_transit_gateway_IncorrectState: retry on IncorrectState

Do not immediately bail out in case of IncorrectState error. We now
instead wait and retry.

E.g: https://ddf1d621d7b816539203-e56a3e9170eb32404c2ff3e77b13356f.ssl.cf2.rackcdn.com/799/690df9c2d3f69323837542b96fa7318650fd5308/check/integration-community.aws-1/f30fb4f/job-output.txt
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Oct 24, 2023
@tremble
ec2_transit_gateway_vpc_attachment - retry on IncorrectState (ansible…
3347cb0 
…-collections#1147)

ec2_transit_gateway_vpc_attachment - retry on IncorrectState

SUMMARY
Follows on from ansible-collections#1110 - to retry ec2_transit_gateway_vpc_attachment failures
Doing this separately because it's not in the stable-3 branch.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_transit_gateway_vpc_attachment
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module_utils module_utils needs_triage plugins plugin (any type)
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Remove deprecated CloudRetry.backoff (and AWSRetry.backoff) tremble/amazon.aws
2 participants
@tremble @ansibullbot