Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.0.0] route53_health_check - Make health_check_name a required parameter #1111

Closed
1 task done
tremble opened this issue Oct 5, 2022 · 4 comments
Closed
1 task done

[6.0.0] route53_health_check - Make health_check_name a required parameter #1111

tremble opened this issue Oct 5, 2022 · 4 comments
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type)
Milestone
6.0.0

Comments

@tremble
Copy link
Contributor

tremble commented Oct 5, 2022

Summary

We've announced that health_check_name will become a required parameter. Either reverse the decision or implement it prior to 6.0.0

Issue Type

Feature Idea

Component Name

plugins/modules/route53_health_check.py

Additional Information

Original deprecation: ansible-collections/community.aws#1143

575     if module.params.get('use_unique_names') or module.params.get('health_check_id'):
576         module.deprecate(
577             'The health_check_name is currently non required parameter.'
578             ' This behavior will change and health_check_name '
579             ' will change to required=True and use_unique_names will change to default=True in release 6.0.0.',
580             version='6.0.0', collection_name='amazon.aws')

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@tremble tremble added this to the 6.0.0 milestone Oct 5, 2022
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

cc @jillr @s-hertel @zimbatm
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module needs_triage plugins plugin (any type) labels Oct 5, 2022
saito-hideki pushed a commit to saito-hideki/amazon.aws that referenced this issue Oct 18, 2022
@jatorcasso @goneri
lambda - fix check mode on creation (ansible-collections#1108)
3499d29 
lambda - fix check mode on creation

Depends-On: ansible-collections#1116
SUMMARY

When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating".

Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported.

Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure.

Fixes ansible-collections#1111
ISSUE TYPE

Feature Pull Request
Bugfix Pull Request

COMPONENT NAME
lambda

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <git@osuv.de>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@0bde6bb
@tremble
Copy link
Contributor Author

tremble commented Jan 9, 2023

@mandar242,

Git's blaming you (ansible-collections/community.aws#1143) any chance you could take a look at this?

@tremble
Copy link
Contributor Author

tremble commented Feb 5, 2023

Abandoned.

@tremble tremble closed this as completed Feb 5, 2023
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
@jatorcasso
lambda - fix check mode on creation (ansible-collections#1108)
ecb8923 
lambda - fix check mode on creation

Depends-On: ansible-collections#1116
SUMMARY


When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating".


Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported.


Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure.


Fixes ansible-collections#1111
ISSUE TYPE

Feature Pull Request
Bugfix Pull Request

COMPONENT NAME
lambda

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
@jatorcasso @abikouo
lambda - fix check mode on creation (ansible-collections#1108)
b94d804 
lambda - fix check mode on creation

Depends-On: ansible-collections#1116
SUMMARY


When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating".


Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported.


Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure.


Fixes ansible-collections#1111
ISSUE TYPE

Feature Pull Request
Bugfix Pull Request

COMPONENT NAME
lambda

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Oct 24, 2023
@jatorcasso
lambda - fix check mode on creation (ansible-collections#1108)
0bde6bb 
lambda - fix check mode on creation

Depends-On: ansible-collections#1116
SUMMARY


When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating".


Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported.


Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure.


Fixes ansible-collections#1111
ISSUE TYPE

Feature Pull Request
Bugfix Pull Request

COMPONENT NAME
lambda

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <git@osuv.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type)
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
3 participants
@goneri @tremble @ansibullbot