Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for TLS listeners in elbv2 module_utils #1198

Closed
1 task done
anjo-swe opened this issue Oct 25, 2022 · 1 comment · Fixed by #1884
Closed
1 task done

Add support for TLS listeners in elbv2 module_utils #1198

anjo-swe opened this issue Oct 25, 2022 · 1 comment · Fixed by #1884
Assignees
@abikouo
Labels
feature This issue/PR relates to a feature request jira

Comments

@anjo-swe
Copy link
Contributor

Summary

Currently it's not possible to change the Ssl Policy or ALPN Policy of TLS listener of a Network Load Balancer due to the listener is never added to listeners_to_modify

Need something similar to the block we have for HTTPS - https://github.com/ansible-collections/amazon.aws/blob/main/plugins/module_utils/elbv2.py#L759-L772

References

Issue Type

Feature Idea

Component Name

elbv2 (module_utils)

Additional Information



Code of Conduct


    

  •  I agree to follow the Ansible Code of Conduct
    • 


      		
    

      
  





        


            

              
            

        

      


      
    








      

    



      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      



      

  


  

    

  





      


        


  
    

      
          
Files identified in the description:

None


If these files are inaccurate, please update the component name section of the description or use the !component bot command.


click here for bot help


      		
    

  





        


            

              
            

        

      


      

            
  

    
  
  

  

  



    












      

  
          

  

    
  

  


    

        @ansibullbot
ansibullbot




          added
      

  feature

  This issue/PR relates to a feature request

      

  needs_triage


  labels


    Oct 25, 2022

  





  


  


  
    
  
  

    
  abikouo 

      pushed a commit
        to abikouo/amazon.aws
      that referenced
      this issue

    
      Sep 18, 2023
    
    

      


  

    

      


  

      
        @tremble
  





      

        
          Tagging fragment - Move simplest cases over to the docs fragment. (an…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          83e96b5
        
      

    

  

    

      
…sible-collections#1198)

Tagging fragment - networkfirewall - Move over to the docs fragment 

SUMMARY
The networkfirewall tests are slow enough to be flakey, split this off.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
networkfirewall
ADDITIONAL INFORMATION
The change itself was approved on ansible-collections#1182

    




    

  




  


  
    
  
  

    
  abikouo 

      pushed a commit
        to abikouo/amazon.aws
      that referenced
      this issue

    
      Sep 18, 2023
    
    

      


  

    

      


  

      
        @tremble
      
        @abikouo
  





      

        
          Tagging fragment - Move simplest cases over to the docs fragment. (an…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          d201e38
        
      

    

  

    

      
…sible-collections#1198)

Tagging fragment - networkfirewall - Move over to the docs fragment 

SUMMARY
The networkfirewall tests are slow enough to be flakey, split this off.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
networkfirewall
ADDITIONAL INFORMATION
The change itself was approved on ansible-collections#1182

    




    

  




  


  
    
  
  

    
  abikouo 

      pushed a commit
        to abikouo/amazon.aws
      that referenced
      this issue

    
      Oct 24, 2023
    
    

      


  

    

      


  

      
        @tremble
  





      

        
          Tagging fragment - Move simplest cases over to the docs fragment. (an…
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          b351af5
        
      

    

  

    

      
…sible-collections#1198)

Tagging fragment - networkfirewall - Move over to the docs fragment 

SUMMARY
The networkfirewall tests are slow enough to be flakey, split this off.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
networkfirewall
ADDITIONAL INFORMATION
The change itself was approved on ansible-collections#1182

    




    

  




  

  

    
  

  


    

        @abikouo
abikouo




            self-assigned this


    Nov 27, 2023

  





  

  

    
  


  

      

    @abikouo
abikouo



    mentioned this issue
    
      Nov 28, 2023
    





  


  

      
   Merged

  







  




  

  


  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Dec 8, 2023
    
    

      


  

    

      


  

      
        @abikouo
  





      

        
          module_utils/elbv2 - supports update for TLS listeners (#1884)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          bf1cb9a
        
      

    

  

    

      
module_utils/elbv2 - supports update for TLS listeners

SUMMARY

closes #1198

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

module_utils/elbv2
ADDITIONAL INFORMATION

Reviewed-by: Helen Bailey <hebailey@redhat.com>
Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS
Reviewed-by: Alina Buzachis

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
    @abikouo
  
    abikouo
    

      








      


  


  

    Labels
  



    

      

    feature

  This issue/PR relates to a feature request
  

    jira









      

  

    

        

    Projects
  


        




    None yet




  



      

  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




            
Successfully merging a pull request may close this issue.





    


  
          
      module_utils/elbv2 - supports update for TLS listeners

    
      abikouo/amazon.aws
    





    
  




        
      

    

  
      

  

    

      4 participants
    

    

        
          @anjo-swe 
        
          @GomathiselviS 
        
          @ansibullbot 
        
          @abikouo