Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipaddress module is removed in ansible.netcommon >=2.0.0 #273

Closed
irl opened this issue Mar 3, 2021 · 10 comments · Fixed by #282
Closed

ipaddress module is removed in ansible.netcommon >=2.0.0 #273

irl opened this issue Mar 3, 2021 · 10 comments · Fixed by #282
Assignees
@Akasurde
Labels
feature This issue/PR relates to a feature request has_pr needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly

Comments

@irl
Copy link

irl commented Mar 3, 2021

There was a major version bump yesterday on ansible.netcommon and now this is broken.

ansible-collections/ansible.netcommon@8cda0e6

amazon.aws/plugins/modules/ec2_group.py

Line 410 in 76aeec2

from ansible_collections.ansible.netcommon.plugins.module_utils.compat.ipaddress import IPv6Network
and perhaps other locations.
@ansibullbot
Copy link

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

@irl: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

  • component name

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE/bug_report.md

click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage labels Mar 3, 2021
@irl
Copy link
Author

irl commented Mar 3, 2021

The template is 404 not found, I'm not sure what is meant by component name but I've linked to an example in the code.

@abeluck
Copy link

abeluck commented Mar 3, 2021 •
edited
Loading

We're seeing this too. netcommon released 2.0 which removed this module util file depended on by ec2_group

edit: removed unwarranted rudeness. my apologies.

@Akasurde
Copy link
Member

Akasurde commented Mar 3, 2021

@irl @abeluck Thanks for providing this feedback. I think we need to add a dependency for netcommon here =

amazon.aws/galaxy.yml

Line 11 in 76aeec2

ansible.netcommon: '>=0.0.1'
so that installation of amazon.aws won't break.

@Akasurde Akasurde self-assigned this Mar 3, 2021
@Akasurde Akasurde removed needs_info This issue requires further information. Please answer any outstanding questions needs_triage labels Mar 3, 2021
@ansibullbot ansibullbot added the needs_info This issue requires further information. Please answer any outstanding questions label Mar 3, 2021
Akasurde added a commit to Akasurde/amazon.aws that referenced this issue Mar 3, 2021
@Akasurde
galaxy: Fix ansible.common collection version
253086f 
ansible.common removed ipaddress which is required by ec2_group module.
Fix ansible.common version <2.0.0 to handle this dependency.

Fixes: ansible-collections#273

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde mentioned this issue Mar 3, 2021
Closed
@Akasurde
Copy link
Member

Akasurde commented Mar 3, 2021

resolved_by_pr #274

@Akasurde
Copy link
Member

Akasurde commented Mar 3, 2021

@irl @abeluck Could you please check if #274 fixes your issue and let me know? Thanks.

@irl
Copy link
Author

irl commented Mar 3, 2021

@irl @abeluck Could you please check if #274 fixes your issue and let me know? Thanks.

I've not run the code but the concept is good. Manually pinning ansible.netcommon to 1.5.0 worked for me earlier today and I assume this has the same effect.

@jillr
Copy link
Collaborator

jillr commented Mar 3, 2021

@Akasurde This isn't working for CI; we'll also need something like I've got here (I think I've got it mostly working there). #275
Would you mind updating this PR so we can land these changes together?

@goneri
Copy link
Member

goneri commented Mar 4, 2021

We should actually be able do just drop the dep: See: #278

@goneri goneri mentioned this issue Mar 4, 2021
Closed
@jillr jillr mentioned this issue Mar 4, 2021
Merged
@jillr jillr closed this as completed in #282 Mar 5, 2021
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
@GiuseppeChiesa-TomTom
fix chunk_size calculation by using boto3 S3 Transport defaults (ansi…
1cbfb64 
…ble-collections#273)

* fix chunk_size calculation by using boto3 S3 Transport defaults since defaults are used also for the upload function
* implemented some integration tests for s3_sync
* added changelog fragment
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
@GiuseppeChiesa-TomTom @abikouo
fix chunk_size calculation by using boto3 S3 Transport defaults (ansi…
0dccd0c 
…ble-collections#273)

* fix chunk_size calculation by using boto3 S3 Transport defaults since defaults are used also for the upload function
* implemented some integration tests for s3_sync
* added changelog fragment
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Oct 24, 2023
@GiuseppeChiesa-TomTom
fix chunk_size calculation by using boto3 S3 Transport defaults (ansi…
a159cd7 
…ble-collections#273)

* fix chunk_size calculation by using boto3 S3 Transport defaults since defaults are used also for the upload function
* implemented some integration tests for s3_sync
* added changelog fragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Akasurde Akasurde

Labels
feature This issue/PR relates to a feature request has_pr needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly
Projects
None yet
Milestone
No milestone
6 participants
@goneri @Akasurde @irl @abeluck @jillr @ansibullbot