Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_vol - add support for modifying existing volumes #55

Closed
briantist opened this issue May 20, 2020 · 7 comments
Closed

ec2_vol - add support for modifying existing volumes #55

briantist opened this issue May 20, 2020 · 7 comments
Labels
affects_2.10 feature This issue/PR relates to a feature request has_pr module module plugins plugin (any type)

Comments

@briantist
Copy link
Contributor

SUMMARY

This is a re-submission of ansible/ansible#21588

A PR was opened to implement this but was ultimately closed without being merged seemingly due to disagreements over whether to require a complete port of the module to boto3:
ansible/ansible#22978

The need for the feature, particularly for expanding existing volumes, is still very real though.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

ec2_vol

ADDITIONAL INFORMATION
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

@ansibullbot ansibullbot added affects_2.10 feature This issue/PR relates to a feature request module module needs_triage labels Aug 19, 2020
@ansibullbot ansibullbot added the plugins plugin (any type) label Aug 27, 2020
@roy-boy
Copy link

roy-boy commented Sep 11, 2020

Any update on this one or we just waiting 2.10 to be released?

@tremble
Copy link
Contributor

tremble commented Sep 11, 2020

@roy-boy As it stands the ec2_vol module is a boto (v2) based module and I believe the original boto python module doesn't support changing the size of volumes. While it's possible to create a hybrid boto/boto3 module (as done in ansible/ansible#22978) this generally results in a much higher risk of bugs creeping into the module as boto and boto3 have very different approaches to parameters, return values and exceptions.

There's a port of this module to boto3 in progress (#53). However, the bulk of contributors to both ansible.aws and community.aws are 'community' contributors and not directly paid to work on Ansible collections. As such, turn around can be much slower than people may like. Once #53 is merged reviving ansible/ansible#22978 should be relatively trivial.

@roy-boy
Copy link

roy-boy commented Sep 14, 2020

@tremble , thanks for your reply, yeah understand the release cycle of open source project. No worries I can use python boto3 now as the workaround for my project and keep an eye on the 2.10 release notes. Cheers!

@markuman
Copy link
Member

markuman commented Dec 6, 2020

#215

@markuman
Copy link
Member

markuman commented Mar 1, 2021

closed by #215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.10 feature This issue/PR relates to a feature request has_pr module module plugins plugin (any type)
Projects
None yet
Development

No branches or pull requests

6 participants