Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3: empty __init__.py can be removed #1018

Conversation

goneri
Copy link
Member

@goneri goneri commented Sep 13, 2022

Since we are Python3 (PEP-420), these empty __init__.py files are
not required anymore.
pytest is still able to discover the test files.

@ansibullbot
Copy link

@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibullbot
Copy link

@ansibullbot ansibullbot added action action plugin callback callback plugin inventory inventory plugin lookup lookup plugin module module module_utils module_utils needs_info This issue requires further information. Please answer any outstanding questions needs_maintainer needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage plugins plugin (any type) python3 tests tests labels Sep 13, 2022
@goneri goneri force-pushed the python3-empty-__init__.py-can-be-removed_29172 branch from b02fab8 to ff09ce8 Compare September 13, 2022 15:17
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 34s
✔️ build-ansible-collection SUCCESS in 5m 49s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 00s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 11m 11s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 52s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 25s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 36s
✔️ ansible-test-splitter SUCCESS in 2m 50s
✔️ integration-amazon.aws-1 SUCCESS in 5m 58s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
ansible-test-changelog FAILURE in 2m 30s

Since we are Python3 (PEP-420), these empty `__init__.py` files are
not required anymore.
`pytest` is still able to discover the test files.
@goneri goneri force-pushed the python3-empty-__init__.py-can-be-removed_29172 branch from ff09ce8 to 329ee9d Compare September 13, 2022 15:54
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 44s
✔️ build-ansible-collection SUCCESS in 5m 47s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 44s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 37s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 25s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 53s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 16s
✔️ ansible-test-splitter SUCCESS in 3m 10s
✔️ integration-amazon.aws-1 SUCCESS in 5m 58s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 33s

@goneri goneri added the mergeit Merge the PR (SoftwareFactory) label Sep 21, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 5m 18s
✔️ build-ansible-collection SUCCESS in 5m 54s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 54s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 11m 41s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 22s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 43s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 8m 29s
✔️ ansible-test-splitter SUCCESS in 3m 14s
✔️ integration-amazon.aws-1 SUCCESS in 12m 34s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 3m 05s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b40b6f1 into ansible-collections:main Sep 21, 2022
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action action plugin callback callback plugin inventory inventory plugin lookup lookup plugin mergeit Merge the PR (SoftwareFactory) module_utils module_utils module module needs_info This issue requires further information. Please answer any outstanding questions needs_maintainer needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly plugins plugin (any type) python3 tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants