Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AttributeError: 'AnsibleAWSModule' object has no attribute 'fail' error #1045

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Fix AttributeError: 'AnsibleAWSModule' object has no attribute 'fail' error #1045

merged 1 commit into from
Sep 21, 2022

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Sep 21, 2022

SUMMARY

When passing both a profile and credentials we now fail, however we called fail rather than fail_json. This results in:

File \"/tmp/ansible_amazon.aws.aws_caller_info_payload_e_b294g4/ansible_amazon.aws.aws_caller_info_payload.zip/ansible_collections/amazon/aws/plugins/module_utils/modules.py\", line 188, in client
File \"/tmp/ansible_amazon.aws.aws_caller_info_payload_e_b294g4/ansible_amazon.aws.aws_caller_info_payload.zip/ansible_collections/amazon/aws/plugins/module_utils/botocore.py\", line 186, in get_aws_connection_info
AttributeError: 'AnsibleAWSModule' object has no attribute 'fail'",
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/module_utils/botocore.py

ADDITIONAL INFORMATION

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module_utils module_utils needs_triage plugins plugin (any type) tests tests labels Sep 21, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 27s
✔️ build-ansible-collection SUCCESS in 5m 29s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 41s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 51s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 46s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 56s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 4m 56s
✔️ ansible-test-splitter SUCCESS in 3m 16s
✔️ integration-amazon.aws-1 SUCCESS in 7m 05s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 41m 51s
✔️ integration-community.aws-2 SUCCESS in 32m 14s
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 13s

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Sep 21, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 5m 13s
✔️ build-ansible-collection SUCCESS in 5m 54s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 14m 33s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 13m 00s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 13m 07s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 11m 30s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 8m 02s
✔️ ansible-test-splitter SUCCESS in 3m 13s
✔️ integration-amazon.aws-1 SUCCESS in 14m 43s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 7m 47s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 31s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 70afe74 into ansible-collections:main Sep 21, 2022
@tremble tremble deleted the botocore/missing_fail branch September 23, 2022 11:46
@renovate renovate bot mentioned this pull request Oct 4, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Oct 27, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@abikouo abikouo abikouo approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) module_utils module_utils needs_triage plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tremble @alinabuzachis @abikouo @ansibullbot