Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure remaining _info modules support check_mode #107

Merged
merged 2 commits into from
Jul 20, 2020

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 14, 2020

SUMMARY

They make no changes, it's standard for _info modules to still return status

fixes: #106

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aws_az_info
ec2_eni_info
ec2_snapshot_info

ADDITIONAL INFORMATION

Copy link
Member

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (changelog fragement?)


- assert:
that:
- info_check is successful
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor but I would test here for not changed.

They make no changes, it's standard for them to still return status
@jillr jillr merged commit 88594a3 into ansible-collections:main Jul 20, 2020
@tremble tremble deleted the issues/106 branch May 28, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_az_info: missing check_mode support
3 participants