-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Work around for #1083 (#1086)" #1094
Merged
softwarefactory-project-zuul
merged 2 commits into
ansible-collections:main
from
tremble:cleanup/5.0.0/spec_none
Sep 30, 2022
Merged
Revert "Work around for #1083 (#1086)" #1094
softwarefactory-project-zuul
merged 2 commits into
ansible-collections:main
from
tremble:cleanup/5.0.0/spec_none
Sep 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
added
the
do_not_backport
This PR should not be backported to stable- branches unless absolutely necessary
label
Sep 30, 2022
ansibullbot
added
community_review
feature
This issue/PR relates to a feature request
module_utils
module_utils
plugins
plugin (any type)
labels
Sep 30, 2022
This comment was marked as resolved.
This comment was marked as resolved.
goneri
approved these changes
Sep 30, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
do_not_backport
This PR should not be backported to stable- branches unless absolutely necessary
feature
This issue/PR relates to a feature request
mergeit
Merge the PR (SoftwareFactory)
module_utils
module_utils
plugins
plugin (any type)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e0aeafd.
SUMMARY
Following #1087 we no longer need the workaround for #1083.
The work around has been backported to stable-4, which still announces support for Ansible 2.9, however we've now dropped support for 2.9 so don't need this in main/5.0.0
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/cloud.py
ADDITIONAL INFORMATION