Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Work around for #1083 (#1086)" #1094

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Sep 30, 2022

This reverts commit e0aeafd.

SUMMARY

Following #1087 we no longer need the workaround for #1083.

The work around has been backported to stable-4, which still announces support for Ansible 2.9, however we've now dropped support for 2.9 so don't need this in main/5.0.0

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/module_utils/cloud.py

ADDITIONAL INFORMATION

@tremble tremble added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label Sep 30, 2022
@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module_utils module_utils plugins plugin (any type) labels Sep 30, 2022
@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 11s
✔️ build-ansible-collection SUCCESS in 6m 29s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 17s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 51s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 12m 12s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 4m 47s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 08s
✔️ ansible-test-splitter SUCCESS in 2m 35s
⚠️ integration-amazon.aws-1 SKIPPED
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 14s

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Sep 30, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 57s
✔️ build-ansible-collection SUCCESS in 5m 05s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 12m 01s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 37s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 11m 02s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 48s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 57s
✔️ ansible-test-splitter SUCCESS in 2m 47s
⚠️ integration-amazon.aws-1 SKIPPED
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 23s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b553d94 into ansible-collections:main Sep 30, 2022
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@tremble tremble deleted the cleanup/5.0.0/spec_none branch October 21, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review do_not_backport This PR should not be backported to stable- branches unless absolutely necessary feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module_utils module_utils plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants