Refacterization of code to use 'fallback' instead of using os.environ #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
refacter/connection-fallback
branch
from
e476f66
to
93e73a1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
refacter/connection-fallback
branch
from
93e73a1
to
0bd1b85
Compare
goneri
approved these changes
Oct 17, 2022
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1224 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 29, 2022
…#1174) Refacterization of code to use 'fallback' instead of using os.environ SUMMARY When the "ec2" module was first added, it included support for pulling credentials out of the environment variables. 3.5 years later, in Ansible 2.1, support for configuring a 'fallback' directly in the argument specification was added, but we never got around to using it. This PR finally cleans up the code and lets the argument parser directly handle fallback to environment variables. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/botocore.py plugins/module_utils/modules.py ADDITIONAL INFORMATION Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> (cherry picked from commit 9401932)
Closed
1 task
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Nov 1, 2022
…#1174) (#1224) [PR #1174/9401932f backport][stable-5] Refacterization of code to use 'fallback' instead of using os.environ This is a backport of PR #1174 as merged into main (9401932). SUMMARY When the "ec2" module was first added, it included support for pulling credentials out of the environment variables. 3.5 years later, in Ansible 2.1, support for configuring a 'fallback' directly in the argument specification was added, but we never got around to using it. This PR finally cleans up the code and lets the argument parser directly handle fallback to environment variables. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/botocore.py plugins/module_utils/modules.py ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Add changelog fragment for amazon.aws/825 SUMMARY With ansible-collections#825 we now ignore aws: tags when purging. Since affects both amazon.aws and community.aws add a changelog note to community.aws ISSUE TYPE Docs Pull Request COMPONENT NAME changelogs/fragments/817-skip_purge_aws.yaml ADDITIONAL INFORMATION See also: ansible-collections#825 ansible-collections#817 ansible-collections#1146 Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When the "ec2" module was first added, it included support for pulling credentials out of the environment variables. 3.5 years later, in Ansible 2.1, support for configuring a 'fallback' directly in the argument specification was added, but we never got around to using it.
This PR finally cleans up the code and lets the argument parser directly handle fallback to environment variables.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/botocore.py
plugins/module_utils/modules.py
ADDITIONAL INFORMATION