route53_health_check: add support for enabling latency graphs #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
abikouo
approved these changes
Oct 27, 2022
alinabuzachis
approved these changes
Oct 28, 2022
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Nov 1, 2022
route53_health_check: bump up version_added for measure_latency SUMMARY With amazon.aws 5.1.0 release before merging #1201 , changing version_added for measure_latency to 5.2.0 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_health_check Reviewed-by: Alina Buzachis <None>
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1432 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
route53_health_check: add support for enabling latency graphs SUMMARY Fixes #1189 Add support for enabling Latency graphs (MeasureLatency) during creation of a Route53 Health Check. ISSUE TYPE Feature Pull Request COMPONENT NAME route53_health_check ADDITIONAL INFORMATION You can't change the value of MeasureLatency after you create a health check. Reviewed-by: Alina Buzachis <None> Reviewed-by: Bikouo Aubin <None> (cherry picked from commit 63cca2c)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
…ort for enabling latency graphs (#1432) [PR #1201/63cca2ce backport][stable-5] route53_health_check: add support for enabling latency graphs This is a backport of PR #1201 as merged into main (63cca2c). SUMMARY Fixes #1189 Add support for enabling Latency graphs (MeasureLatency) during creation of a Route53 Health Check. ISSUE TYPE Feature Pull Request COMPONENT NAME route53_health_check ADDITIONAL INFORMATION You can't change the value of MeasureLatency after you create a health check. Reviewed-by: Mark Chappell
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Tagging - ec2_snapshot_copy SUMMARY Add the "resource_tags" alias, for consistency with other modules minor docs clean-up Use TagSpecification on creation rather than making a separate API call to tag the resource after creation. Does not add purge_tags, since the module performs a one-shot action rather than managing the resources. ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME ec2_snapshot_copy ADDITIONAL INFORMATION Since we don't have a tags-only fragment, I've not switched this over to using a fragment. If I find more modules with a similar use-case I'll try to find a standard fragment we can use. Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Tagging - ec2_snapshot_copy SUMMARY Add the "resource_tags" alias, for consistency with other modules minor docs clean-up Use TagSpecification on creation rather than making a separate API call to tag the resource after creation. Does not add purge_tags, since the module performs a one-shot action rather than managing the resources. ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME ec2_snapshot_copy ADDITIONAL INFORMATION Since we don't have a tags-only fragment, I've not switched this over to using a fragment. If I find more modules with a similar use-case I'll try to find a standard fragment we can use. Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Tagging - ec2_snapshot_copy SUMMARY Add the "resource_tags" alias, for consistency with other modules minor docs clean-up Use TagSpecification on creation rather than making a separate API call to tag the resource after creation. Does not add purge_tags, since the module performs a one-shot action rather than managing the resources. ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME ec2_snapshot_copy ADDITIONAL INFORMATION Since we don't have a tags-only fragment, I've not switched this over to using a fragment. If I find more modules with a similar use-case I'll try to find a standard fragment we can use. Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #1189
Add support for enabling Latency graphs (MeasureLatency) during creation of a Route53 Health Check.
ISSUE TYPE
COMPONENT NAME
route53_health_check
ADDITIONAL INFORMATION
You can't change the value of MeasureLatency after you create a health check.