ec2_snapshot_info/tests: add unit-tests #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
This comment was marked as outdated.
This comment was marked as outdated.
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
changed the title
goneri
reviewed
Oct 28, 2022
| def list_ec2_snapshots(connection, module, request_args): | ||
|
|
||
| try: | ||
| snapshots = get_snapshots(connection, module, request_args) |
There was a problem hiding this comment.
Since exit_json() actually call exit() syscall, I would advice to just return a dict and call module.exit_json() from outside of the function. This way, to can test the behaviour of your function just by checking the output.
goneri
approved these changes
Nov 1, 2022
|
recheck |
|
recheck |
|
This change depends on a change that failed to merge. |
|
recheck |
|
recheck |
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…s#1211) wafv2_ip_set - fix bugs with changing description SUMMARY updating just the description didn't update the changed state ISSUE TYPE Bugfix Pull Request COMPONENT NAME wafv2_ip_set ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…s#1211) wafv2_ip_set - fix bugs with changing description SUMMARY updating just the description didn't update the changed state ISSUE TYPE Bugfix Pull Request COMPONENT NAME wafv2_ip_set ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…s#1211) wafv2_ip_set - fix bugs with changing description SUMMARY updating just the description didn't update the changed state ISSUE TYPE Bugfix Pull Request COMPONENT NAME wafv2_ip_set ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #1234
Depends-On: #1235
SUMMARY
list_ec2_snapshotsto moveconnection.describe_snapshotsto separate method.COMPONENT NAME
ec2_snapshot_info
ADDITIONAL INFO
latest CI run coverage report plugins_modules_ec2_snapshot_info_py.html