ec2_vpc_nat_gateway: Add support for connectivity_type = private #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GomathiselviS <gomathiselvi@gmail.com>
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
mandar242
approved these changes
Nov 15, 2022
goneri
reviewed
Nov 15, 2022
goneri
reviewed
Nov 15, 2022
| @@ -544,13 +552,14 @@ def release_address(client, module, allocation_id): | |||
|
|
|||
|
|
|||
| def create(client, module, subnet_id, allocation_id, tags, client_token=None, | |||
There was a problem hiding this comment.
I could be nice to cover the params dict creation with a unit-tests.
There was a problem hiding this comment.
I would like to create a separate PR to add unit test cases for the complete module.
goneri
approved these changes
Nov 15, 2022
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Apr 27, 2023
…ible-collections#1267) ec2_vpc_nat_gateway: Add support for connectivity_type = private Signed-off-by: GomathiselviS gomathiselvi@gmail.com SUMMARY Fixes: ansible-collections#1260 This PR adds a key 'connectivity_type' to ec2_vpc_nat_gateway module ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: GomathiselviS <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Apr 28, 2023
…) (#1486) [manual backport stable-5] ec2_vpc_nat_gateway: Add support for connectivity_type = private (#1267) ec2_vpc_nat_gateway: Add support for connectivity_type = private Signed-off-by: GomathiselviS gomathiselvi@gmail.com SUMMARY Fixes: #1260 This PR adds a key 'connectivity_type' to ec2_vpc_nat_gateway module ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mandar Kulkarni mandar242@gmail.com Reviewed-by: Gonéri Le Bouder goneri@lebouder.net Reviewed-by: GomathiselviS SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY
Fixes: #1260
This PR adds a key 'connectivity_type' to ec2_vpc_nat_gateway module
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION