Refactor inventory plugin connection handling #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
refacter/inventories/connection
branch
from
b932b4a
to
4ecfe66
Compare
tremble
force-pushed
the
refacter/inventories/connection
branch
from
4ecfe66
to
39c2ccd
Compare
1 task
tremble
requested review from
abikouo,
alinabuzachis and
jillr
and removed request for
abikouo
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
refacter/inventories/connection
branch
from
39c2ccd
to
5a5796f
Compare
| options: {} | ||
| """ | ||
|
|
||
| # Formatted for non-module plugins |
There was a problem hiding this comment.
Is it worth adding a note in the README about this doc_fragment?
There was a problem hiding this comment.
The scope is currently limited to inventory plugins, so I wasn't going to add one just yet.
alinabuzachis
approved these changes
Nov 22, 2022
plugins/doc_fragments/assume_role.py
Outdated
| @@ -0,0 +1,24 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # Copyright: (c) 2015, Ansible, Inc | |||
There was a problem hiding this comment.
Should it be 2015 or 2022?
There was a problem hiding this comment.
2022, good catch :)
tremble
commented
Nov 22, 2022
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Rename s3 modules SUMMARY In line with the naming guidelines, removes the aws_ prefix from aws_s3_bucket_info and aws_s3_cors ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_s3_bucket_info.py plugins/modules/aws_s3_cors.py plugins/modules/s3_bucket_info.py plugins/modules/s3_cors.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Rename s3 modules SUMMARY In line with the naming guidelines, removes the aws_ prefix from aws_s3_bucket_info and aws_s3_cors ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_s3_bucket_info.py plugins/modules/aws_s3_cors.py plugins/modules/s3_bucket_info.py plugins/modules/s3_cors.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 29, 2023
Rename s3 modules SUMMARY In line with the naming guidelines, removes the aws_ prefix from aws_s3_bucket_info and aws_s3_cors ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_s3_bucket_info.py plugins/modules/aws_s3_cors.py plugins/modules/s3_bucket_info.py plugins/modules/s3_cors.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@dd8b18e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 2, 2023
Rename s3 modules SUMMARY In line with the naming guidelines, removes the aws_ prefix from aws_s3_bucket_info and aws_s3_cors ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_s3_bucket_info.py plugins/modules/aws_s3_cors.py plugins/modules/s3_bucket_info.py plugins/modules/s3_cors.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@dd8b18e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 2, 2023
Rename s3 modules SUMMARY In line with the naming guidelines, removes the aws_ prefix from aws_s3_bucket_info and aws_s3_cors ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_s3_bucket_info.py plugins/modules/aws_s3_cors.py plugins/modules/s3_bucket_info.py plugins/modules/s3_cors.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@dd8b18e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 2, 2023
Rename s3 modules SUMMARY In line with the naming guidelines, removes the aws_ prefix from aws_s3_bucket_info and aws_s3_cors ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_s3_bucket_info.py plugins/modules/aws_s3_cors.py plugins/modules/s3_bucket_info.py plugins/modules/s3_cors.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@dd8b18e
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 6, 2023
Rename s3 modules SUMMARY In line with the naming guidelines, removes the aws_ prefix from aws_s3_bucket_info and aws_s3_cors ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_s3_bucket_info.py plugins/modules/aws_s3_cors.py plugins/modules/s3_bucket_info.py plugins/modules/s3_cors.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@dd8b18e
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Rename s3 modules SUMMARY In line with the naming guidelines, removes the aws_ prefix from aws_s3_bucket_info and aws_s3_cors ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_s3_bucket_info.py plugins/modules/aws_s3_cors.py plugins/modules/s3_bucket_info.py plugins/modules/s3_cors.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Further refactors inventory plugin connection handling:
_boto3_conntoall_clientsto better describe what it's doing (_boto3_connis used elswhere for singluar clients)ISSUE TYPE
COMPONENT NAME
plugins/inventory/aws_ec2.py
plugins/inventory/aws_rds.py
plugins/plugin_utils/base.py
plugins/plugin_utils/inventory.py
ADDITIONAL INFORMATION