Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0.0] ec2_instance - Drop default value for instance_type #1315

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jan 4, 2023

SUMMARY

Deprecation period was set to end 2023-01-01. This has now passed.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_instance

ADDITIONAL INFORMATION

@tremble tremble added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label Jan 4, 2023
@tremble tremble force-pushed the deprecation/remove/6.0.0/ec2_instance branch from 3b346f8 to 531787c Compare January 4, 2023 08:54
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jan 4, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 27s
✔️ build-ansible-collection SUCCESS in 5m 39s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 14m 32s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 44s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 13s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 14m 52s
ansible-test-units-amazon-aws-python36 FAILURE in 10m 24s
ansible-test-units-amazon-aws-python38 FAILURE in 10m 34s
ansible-test-units-amazon-aws-python39 FAILURE in 9m 25s
ansible-test-units-amazon-aws-python310 FAILURE in 6m 16s
cloud-tox-py3 FAILURE in 5m 30s
✔️ ansible-test-changelog SUCCESS in 2m 17s
✔️ ansible-test-splitter SUCCESS in 2m 47s
✔️ integration-amazon.aws-1 SUCCESS in 45m 01s
✔️ integration-amazon.aws-2 SUCCESS in 38m 59s
✔️ integration-amazon.aws-3 SUCCESS in 39m 42s
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-amazon.aws-19 SKIPPED
⚠️ integration-amazon.aws-20 SKIPPED
⚠️ integration-amazon.aws-21 SKIPPED
⚠️ integration-amazon.aws-22 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 6m 28s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@tremble tremble force-pushed the deprecation/remove/6.0.0/ec2_instance branch from 531787c to ec0ebe4 Compare January 5, 2023 08:04
@tremble tremble changed the title ec2_instance - Drop default value for instance_type [6.0.0] ec2_instance - Drop default value for instance_type Jan 5, 2023
@tremble tremble added this to the 6.0.0 milestone Jan 5, 2023
@ansibullbot ansibullbot added needs_maintainer tests tests and removed owner_pr PR created by owner/maintainer labels Jan 5, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 19s
✔️ build-ansible-collection SUCCESS in 5m 36s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 11m 27s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 14s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 39s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 9m 23s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 9m 19s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 9m 21s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 9m 46s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 9m 42s
✔️ cloud-tox-py3 SUCCESS in 7m 35s
✔️ ansible-test-changelog SUCCESS in 2m 29s
✔️ ansible-test-splitter SUCCESS in 2m 46s
✔️ integration-amazon.aws-1 SUCCESS in 46m 53s
✔️ integration-amazon.aws-2 SUCCESS in 37m 53s
✔️ integration-amazon.aws-3 SUCCESS in 41m 52s
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-amazon.aws-19 SKIPPED
⚠️ integration-amazon.aws-20 SKIPPED
⚠️ integration-amazon.aws-21 SKIPPED
⚠️ integration-amazon.aws-22 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 5m 25s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@tremble tremble marked this pull request as ready for review January 5, 2023 11:14
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jan 5, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 04s
✔️ build-ansible-collection SUCCESS in 5m 16s
✔️ ansible-test-splitter SUCCESS in 2m 55s
✔️ integration-amazon.aws-1 SUCCESS in 47m 08s
✔️ integration-amazon.aws-2 SUCCESS in 42m 03s
✔️ integration-amazon.aws-3 SUCCESS in 40m 15s
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-amazon.aws-19 SKIPPED
⚠️ integration-amazon.aws-20 SKIPPED
⚠️ integration-amazon.aws-21 SKIPPED
⚠️ integration-amazon.aws-22 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3767b37 into ansible-collections:main Jan 5, 2023
@tremble tremble deleted the deprecation/remove/6.0.0/ec2_instance branch February 15, 2023 09:05
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Rename aws_secrets

SUMMARY
in line with the new naming guidelines rename aws_secret  to secretsmanager_secret
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/modules/aws_secret.py
plugins/modules/secretsmanager_secret.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Rename aws_secrets

SUMMARY
in line with the new naming guidelines rename aws_secret  to secretsmanager_secret
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/modules/aws_secret.py
plugins/modules/secretsmanager_secret.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Rename aws_secrets

SUMMARY
in line with the new naming guidelines rename aws_secret  to secretsmanager_secret
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/modules/aws_secret.py
plugins/modules/secretsmanager_secret.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review do_not_backport This PR should not be backported to stable- branches unless absolutely necessary feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module needs_maintainer plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants