lambda_info and lambda_alias - avoid manipulating module.params #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jillr @pjodouin @ryansb @s-hertel |
ansibullbot
added
community_review
feature
This comment was marked as outdated.
This comment was marked as outdated.
tremble
force-pushed
the
module_params/lambda
branch
from
1de2d5f
to
22efc39
Compare
tremble
force-pushed
the
module_params/lambda
branch
from
22efc39
to
c83cccf
Compare
tremble
commented
Jan 11, 2023
alinabuzachis
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Directly manipulating module.params results in the Ansible output incorrectly representing what was passed to the module, as such we shouldn't be doing this.
ISSUE TYPE
COMPONENT NAME
lambda_info
lambda_alias
ADDITIONAL INFORMATION