Various lint fixups #1350

tremble · 2023-02-04T10:57:56Z

SUMMARY

Minor linting fixups

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ec2_instance
ec2_vpc_nat_gateway
lambda_layer
s3_bucket
plugins/module_utils/s3.py

ADDITIONAL INFORMATION

S3 unused imports aren't in changelog because they're related to unreleased refactoring.

See Also: ansible-collections/news-for-maintainers#34

ansibullbot · 2023-02-04T11:00:31Z

cc @Etherdaemon @abikouo @alinabuzachis @jillr @jonhadfield @linuxdynasty @ryansb @s-hertel
click here for bot help

softwarefactory-project-zuul · 2023-02-04T11:34:56Z

Build succeeded.

softwarefactory-project-zuul · 2023-02-04T12:28:30Z

Build succeeded.

softwarefactory-project-zuul · 2023-02-04T17:23:41Z

Build succeeded (gate pipeline).

patchback · 2023-02-04T17:23:46Z

Backport to stable-5: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply f6755e1 on top of patchback/backports/stable-5/f6755e1caed36e6379ef57be06102a92ee81b743/pr-1350

Backporting merged PR #1350 into main

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-5/f6755e1caed36e6379ef57be06102a92ee81b743/pr-1350 upstream/stable-5

Now, cherry-pick PR Various lint fixups #1350 contents into that branch:
```
$ git cherry-pick -x f6755e1caed36e6379ef57be06102a92ee81b743
```
If it'll yell at you with something like fatal: Commit f6755e1caed36e6379ef57be06102a92ee81b743 is a merge but no -m option was given., add -m 1 as follows intead:
```
$ git cherry-pick -m1 -x f6755e1caed36e6379ef57be06102a92ee81b743
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR Various lint fixups #1350 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-5/f6755e1caed36e6379ef57be06102a92ee81b743/pr-1350

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Various lint fixups SUMMARY Minor linting fixups ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance ec2_vpc_nat_gateway lambda_layer s3_bucket plugins/module_utils/s3.py ADDITIONAL INFORMATION S3 unused imports aren't in changelog because they're related to unreleased refactoring. See Also: ansible-collections/news-for-maintainers#34 Reviewed-by: Felix Fontein <felix@fontein.de>

Various lint fixups

16a7050

ansibullbot added community_review feature This issue/PR relates to a feature request module module module_utils module_utils needs_maintainer needs_triage plugins plugin (any type) tests tests labels Feb 4, 2023

changelog

33a6223

tremble marked this pull request as ready for review February 4, 2023 11:50

tremble requested review from alinabuzachis and felixfontein February 4, 2023 11:52

felixfontein approved these changes Feb 4, 2023

View reviewed changes

tremble added mergeit Merge the PR (SoftwareFactory) backport-5 PR should be backported to the stable-5 branch labels Feb 4, 2023

softwarefactory-project-zuul bot merged commit f6755e1 into ansible-collections:main Feb 4, 2023

tremble mentioned this pull request Feb 4, 2023

[stable-5] Sanity test backports #1351

Merged

tremble deleted the sanity/20230204 branch February 15, 2023 09:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various lint fixups #1350

Various lint fixups #1350

tremble commented Feb 4, 2023

ansibullbot commented Feb 4, 2023

softwarefactory-project-zuul bot commented Feb 4, 2023

softwarefactory-project-zuul bot commented Feb 4, 2023

softwarefactory-project-zuul bot commented Feb 4, 2023

patchback bot commented Feb 4, 2023 •

edited

Loading

Various lint fixups #1350

Various lint fixups #1350

Conversation

tremble commented Feb 4, 2023

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibullbot commented Feb 4, 2023

softwarefactory-project-zuul bot commented Feb 4, 2023

softwarefactory-project-zuul bot commented Feb 4, 2023

softwarefactory-project-zuul bot commented Feb 4, 2023

patchback bot commented Feb 4, 2023 • edited Loading

Backport to stable-5: 💔 cherry-picking failed — conflicts found

Backporting merged PR #1350 into main

patchback bot commented Feb 4, 2023 •

edited

Loading