Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete 'get_classic_link_status' method #1374

Conversation

deronnax
Copy link
Contributor

SUMMARY

fixes #1114

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ec2_vpc_net

ADDITIONAL INFORMATION

I picked the issue to get started into contributing to ansible because it was easy to fix, if I did something wrong just tell and I will get it fixed and improved until the PR eventually passes all checks and get merged.

@tremble
Copy link
Contributor

tremble commented Feb 20, 2023

Thanks for taking the time to open this PR.

2 things

  1. Please add a changelog fragment (https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to)
  2. Please update the integration tests (tests/integration/targets/ec2_vpc_net/tasks/main.yml)

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/14f0ddacd39a474582c229b2c890fe69

✔️ ansible-galaxy-importer SUCCESS in 3m 44s
✔️ build-ansible-collection SUCCESS in 13m 59s
ansible-test-sanity-aws-ansible-python38 RETRY_LIMIT in 1m 29s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 13m 26s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 45s
ansible-test-sanity-aws-ansible-2.14 RETRY_LIMIT in 17s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 12m 04s
ansible-test-units-amazon-aws-python38 RETRY_LIMIT in 18s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 8m 29s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 8m 55s
✔️ cloud-tox-py3 SUCCESS in 8m 15s
ansible-test-changelog FAILURE in 4m 17s
✔️ ansible-test-splitter SUCCESS in 4m 36s
integration-amazon.aws-1 FAILURE in 5m 54s
Skipped 43 jobs

@tremble
Copy link
Contributor

tremble commented Feb 20, 2023

(Please ignore the "RETRY_LIMIT" errors, there was a recent update to the environment which is causing random tests to fail to start)

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d1a3048efb4440fc964e2dd090539318

✔️ ansible-galaxy-importer SUCCESS in 4m 11s
✔️ build-ansible-collection SUCCESS in 13m 22s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 12s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 36s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 09s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 10m 02s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 9m 35s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 9m 51s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 10m 19s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 10m 39s
✔️ cloud-tox-py3 SUCCESS in 9m 20s
ansible-test-changelog FAILURE in 4m 27s
✔️ ansible-test-splitter SUCCESS in 4m 59s
integration-amazon.aws-1 FAILURE in 6m 39s
Skipped 43 jobs

@tremble tremble added this to the 6.0.0 milestone Feb 23, 2023
@github-actions
Copy link

github-actions bot commented Feb 28, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d1a493bb52ff407a91669320344d5c84

✔️ ansible-galaxy-importer SUCCESS in 4m 30s
✔️ build-ansible-collection SUCCESS in 12m 52s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 08s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 55s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 40s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 10m 27s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 9m 33s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 9m 22s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 8m 39s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 9m 30s
✔️ cloud-tox-py3 SUCCESS in 8m 19s
✔️ ansible-test-changelog SUCCESS in 4m 16s
✔️ ansible-test-splitter SUCCESS in 4m 50s
✔️ integration-amazon.aws-1 SUCCESS in 8m 04s
Skipped 43 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Feb 28, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/d1c2af68bbd44228a8253a04e0434332

✔️ ansible-galaxy-importer SUCCESS in 4m 00s
✔️ build-ansible-collection SUCCESS in 13m 09s
✔️ ansible-test-splitter SUCCESS in 4m 48s
✔️ integration-amazon.aws-1 SUCCESS in 8m 42s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 5bdc8f5 into ansible-collections:main Feb 28, 2023
@deronnax
Copy link
Contributor Author

Hello Mark.
I am really sorry I did not come back to it before you did, I have been very busy with job interviews.
Thank you very much for finishing the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[6.0.0] Drop support for EC2 Classic networking
2 participants