Add github action for sanity and unit tests #1393

GomathiselviS · 2023-02-27T21:14:52Z

SUMMARY

Add github action workflow.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

softwarefactory-project-zuul · 2023-02-27T21:27:52Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

softwarefactory-project-zuul · 2023-02-27T22:09:03Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a19a5935e3e845ada11741b3aa22cdc9

✔️ ansible-galaxy-importer SUCCESS in 4m 32s
✔️ build-ansible-collection SUCCESS in 12m 18s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 12m 20s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 11m 59s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 13m 22s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 12m 09s
❌ ansible-test-units-amazon-aws-python36 FAILURE in 7m 12s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 11m 44s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 11m 00s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 12m 47s
✔️ cloud-tox-py3 SUCCESS in 8m 17s

lmilbaum · 2023-02-28T04:14:59Z

I would suggest using pre-commit github action

tremble · 2023-02-28T08:44:08Z

I would suggest using pre-commit github action

It's possible to run many of these tests locally (we should probably do a better job of documenting this), however they usually take a couple of minutes to run, so running them as part of the upload process would probably be frustrating.

Additionally, some folks struggle to understand the errors. It's much easier to collaborate with them once it's uploaded and the errors are publically available,

So I'd recommend not blocking commits or the submission of pushes on broken tests

tremble

In general I like the direction this is taking. Some comments inline.

tremble · 2023-02-28T08:48:38Z

.github/workflows/tests.yml

+
+jobs:
+  ansible-lint:
+    uses: ansible-network/github_actions/.github/workflows/ansible-lint.yml@main


Suggested change

uses: ansible-network/github_actions/.github/workflows/ansible-lint.yml@main

uses: ansible-network/github_actions/.github/workflows/ansible-lint.yml@main

Can we move these from ansible-network out into ansible-community somewhere please? There's a lot of random stuff living under ansible-network and it's really confusing if you're not familiar with the history.

Having them live in ansible-network gives the impression that either they're specifically intended only for the network modules. Or that the ansible-network group are the sole owners of these actions. IMHO they would be better "owned" by the community, and people outside of the network folks may be more inclined to contribute to them.

cc @Qalthos .

I agree with what tremble suggested. @jillr @gravesm?

.github/workflows/tests.yml

tremble · 2023-02-28T09:19:41Z

Looking at actions/runner#2347 I have a concern that we can't do "optional" tests.

There doesn't seem to be a clean way to allow "devel" tests to fail while still blocking merges if the tests fail. GitHub also don't seem interested in offering such a feature :/

Had a quick poke about with "experimental", but I don't see a clean way to do conditional experimental

lmilbaum · 2023-02-28T10:29:00Z

I would suggest using pre-commit github action

It's possible to run many of these tests locally (we should probably do a better job of documenting this), however they usually take a couple of minutes to run, so running them as part of the upload process would probably be frustrating.

Additionally, some folks struggle to understand the errors. It's much easier to collaborate with them once it's uploaded and the errors are publically available,

So I'd recommend not blocking commits or the submission of pushes on broken tests

It is not a must to activate it on local repos. Just invoke it during the CI workflow.

softwarefactory-project-zuul · 2023-02-28T20:17:13Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b5f26bc09e7e410e99307ba11736a71f

✔️ ansible-galaxy-importer SUCCESS in 4m 52s
✔️ build-ansible-collection SUCCESS in 12m 21s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 11m 37s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 12m 11s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 12m 10s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 11m 41s
❌ ansible-test-units-amazon-aws-python36 FAILURE in 9m 27s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 11m 43s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 11m 53s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 12m 01s
✔️ cloud-tox-py3 SUCCESS in 8m 04s
❌ ansible-test-changelog FAILURE in 4m 11s
✔️ ansible-test-splitter SUCCESS in 4m 38s
❌ integration-amazon.aws-1 FAILURE in 8m 09s
✔️ integration-amazon.aws-2 SUCCESS in 9m 34s
Skipped 42 jobs

Cleanup and move tasks (vs playbooks) in inventory tests SUMMARY Inventory plugin tests currently mix "tasks" content in with playbooks, this triggers ansible-lint warnings. ISSUE TYPE Tests Pull Request COMPONENT NAME ec2_vpc_net plugins/inventory/aws_ec2.py plugins/inventory/aws_rds.py ADDITIONAL INFORMATION Spotted by work on #1393 Reviewed-by: Alina Buzachis

softwarefactory-project-zuul · 2023-03-03T16:55:47Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b87f8693b2e345df878978f35e1328fa

.github/workflows/tests.yml

softwarefactory-project-zuul · 2023-03-03T19:42:29Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b2bf72ca96c045c38401ab438eaa863e

✔️ ansible-galaxy-importer SUCCESS in 4m 36s
✔️ build-ansible-collection SUCCESS in 12m 06s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 13m 13s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 12m 36s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 12m 44s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 12m 22s
❌ ansible-test-units-amazon-aws-python36 FAILURE in 9m 42s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 10m 55s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 10m 21s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 12m 40s
✔️ cloud-tox-py3 SUCCESS in 7m 41s
❌ ansible-test-changelog FAILURE in 4m 12s
✔️ ansible-test-splitter SUCCESS in 4m 45s
❌ integration-amazon.aws-1 RETRY_LIMIT in 1m 28s
Skipped 43 jobs

gravesm · 2023-04-18T19:37:38Z

.github/workflows/tests.yml

+
+jobs:
+  linters:
+    uses: abikouo/github_actions/.github/workflows/tox-linters.yml@tox_linters


My preference would be to hold off on merging until we get these changes merged into the ansible-network repo, as I'd like to avoid calling out to personal repos. I won't block on this if people feel strongly that this is worth merging now, but ultimately, I want our CI burden to be shared more broadly than it has been in the past. Otherwise, I think everything looks good.

@jillr suggested that we can go ahead with the merge and not wait until the migration of ansible-network/github_actions repo. PRs on other cloud collections have been merged, which use the workflows from personal repo. @jillr , What do you think about this?

Sorry I thought we were talking about merging things into the repo in the ansible-network org, without waiting for that repo to be migrated to the ansible-community org. Is that not the case?

There are calls to @abikouo's repos which we will update in a separate PR, post the migration of github-actions repo.

tremble · 2023-04-20T08:00:19Z

@jillr For what it's worth we're already pulling from @abikouo's fork in "update collection variables":

 15 jobs: 
 16   update-variables:
 17     uses: abikouo/github_actions/.github/workflows/update_aws_variables.yml@automate_aws_user_agent_variable

I think update_aws_variables.yml probably needs to move into this repo.

abikouo · 2023-04-20T09:14:58Z

@jillr For what it's worth we're already pulling from @abikouo's fork in "update collection variables":
 15 jobs: 
 16   update-variables:
 17     uses: abikouo/github_actions/.github/workflows/update_aws_variables.yml@automate_aws_user_agent_variable
I think update_aws_variables.yml probably needs to move into this repo.

all these calls to personal repo will be changed once we agree where this should live

Minor Sanity test fixes SUMMARY Steal sanity fixes from #1393 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/backup_tag_info.py plugins/modules/backup_vault.py plugins/modules/route53_info.py test-requirements.txt ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis

Co-authored-by: Kate Case <this.is@katherineca.se>

tremble · 2023-04-20T09:39:38Z

The sanity fixes have been merged as #1462 and I've stripped this back to just the GitHub Action related pieces

softwarefactory-project-zuul · 2023-04-20T10:09:14Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2ed9c6c87b15414bbe5c5acfca2dea55

GomathiselviS · 2023-04-20T14:13:16Z

The sanity fixes have been merged as #1462 and I've stripped this back to just the GitHub Action related pieces

Thank you

softwarefactory-project-zuul · 2023-04-20T14:38:06Z

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/8e14cefadab542eaa5e35e9cc6107931

✔️ ansible-galaxy-importer SUCCESS in 5m 34s
✔️ build-ansible-collection SUCCESS in 13m 03s

softwarefactory-project-zuul · 2023-04-20T14:38:09Z

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

GomathiselviS marked this pull request as draft February 27, 2023 21:15

GomathiselviS requested review from tremble, abikouo and jillr February 27, 2023 22:19

tremble requested changes Feb 28, 2023

View reviewed changes

This comment was marked as resolved.

Sign in to view

tremble mentioned this pull request Mar 1, 2023

Cleanup and move tasks (vs playbooks) in inventory tests #1394

Merged

GomathiselviS mentioned this pull request Mar 3, 2023

Add ignore-2.9.txt #1408

Closed

GomathiselviS force-pushed the gha branch from 22a49d3 to 6780504 Compare March 3, 2023 16:31

Qalthos suggested changes Mar 3, 2023

View reviewed changes

.github/workflows/tests.yml Outdated Show resolved Hide resolved

Qalthos reviewed Mar 3, 2023

View reviewed changes

.github/workflows/tests.yml Show resolved Hide resolved

GomathiselviS marked this pull request as ready for review March 3, 2023 19:13

GomathiselviS changed the title ~~WIP: Add github action for sanity and unit tests~~ Add github action for sanity and unit tests Mar 3, 2023

GomathiselviS requested review from Qalthos, tremble and gravesm and removed request for Qalthos March 3, 2023 20:45

alinabuzachis approved these changes Apr 19, 2023

View reviewed changes

gravesm reviewed Apr 19, 2023

View reviewed changes

tremble mentioned this pull request Apr 20, 2023

Minor Sanity test fixes #1462

Merged

GomathiselviS and others added 15 commits April 20, 2023 11:34

Add github action for sanity and unit tests

5cf4efc

Skip ansible-2.9 for sanity

4660b8c

Update .github/workflows/tests.yml

b6c3399

Co-authored-by: Kate Case <this.is@katherineca.se>

Remove unit-galaxy

f5d76c0

add matrix_include

45edf65

Co-authored-by: Kate Case <this.is@katherineca.se>

Skipping py 3.11 for unit tests

c79a322

remove matrix_include

1af196d

remove matrix_include

1c507e2

Add changelog

990709f

Fix ansible-lint errors

253d5fe

Fix sanity issues

12d6ef6

Add ansible-lint exclude_paths

d085d00

Remove ansible-lint

a2cabad

Sanity fix

f624b3d

Fix all_green

745464f

tremble force-pushed the gha branch from a6a634c to 745464f Compare April 20, 2023 09:34

GomathiselviS added the mergeit Merge the PR (SoftwareFactory) label Apr 20, 2023

tremble merged commit 68a36b2 into ansible-collections:main Apr 20, 2023

briantist mentioned this pull request Jun 4, 2023

GitHub Actions CI contention ansible-community/community-topics#237

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add github action for sanity and unit tests #1393

Add github action for sanity and unit tests #1393

GomathiselviS commented Feb 27, 2023

softwarefactory-project-zuul bot commented Feb 27, 2023

softwarefactory-project-zuul bot commented Feb 27, 2023

lmilbaum commented Feb 28, 2023

tremble commented Feb 28, 2023

tremble left a comment

tremble Feb 28, 2023

GomathiselviS Mar 3, 2023

alinabuzachis Mar 6, 2023

tremble commented Feb 28, 2023 •

edited

Loading

lmilbaum commented Feb 28, 2023

This comment was marked as resolved.

This comment was marked as resolved.

softwarefactory-project-zuul bot commented Feb 28, 2023

softwarefactory-project-zuul bot commented Mar 3, 2023

softwarefactory-project-zuul bot commented Mar 3, 2023

gravesm Apr 18, 2023

GomathiselviS Apr 19, 2023

jillr Apr 19, 2023

GomathiselviS Apr 20, 2023

tremble commented Apr 20, 2023

abikouo commented Apr 20, 2023

tremble commented Apr 20, 2023

softwarefactory-project-zuul bot commented Apr 20, 2023

GomathiselviS commented Apr 20, 2023

softwarefactory-project-zuul bot commented Apr 20, 2023

softwarefactory-project-zuul bot commented Apr 20, 2023

	uses: ansible-network/github_actions/.github/workflows/ansible-lint.yml@main
	uses: ansible-network/github_actions/.github/workflows/ansible-lint.yml@main

Add github action for sanity and unit tests #1393

Add github action for sanity and unit tests #1393

Conversation

GomathiselviS commented Feb 27, 2023

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

softwarefactory-project-zuul bot commented Feb 27, 2023

softwarefactory-project-zuul bot commented Feb 27, 2023

lmilbaum commented Feb 28, 2023

tremble commented Feb 28, 2023

tremble left a comment

Choose a reason for hiding this comment

tremble Feb 28, 2023

Choose a reason for hiding this comment

GomathiselviS Mar 3, 2023

Choose a reason for hiding this comment

alinabuzachis Mar 6, 2023

Choose a reason for hiding this comment

tremble commented Feb 28, 2023 • edited Loading

lmilbaum commented Feb 28, 2023

This comment was marked as resolved.

This comment was marked as resolved.

softwarefactory-project-zuul bot commented Feb 28, 2023

softwarefactory-project-zuul bot commented Mar 3, 2023

softwarefactory-project-zuul bot commented Mar 3, 2023

gravesm Apr 18, 2023

Choose a reason for hiding this comment

GomathiselviS Apr 19, 2023

Choose a reason for hiding this comment

jillr Apr 19, 2023

Choose a reason for hiding this comment

GomathiselviS Apr 20, 2023

Choose a reason for hiding this comment

tremble commented Apr 20, 2023

abikouo commented Apr 20, 2023

tremble commented Apr 20, 2023

softwarefactory-project-zuul bot commented Apr 20, 2023

GomathiselviS commented Apr 20, 2023

softwarefactory-project-zuul bot commented Apr 20, 2023

softwarefactory-project-zuul bot commented Apr 20, 2023

tremble commented Feb 28, 2023 •

edited

Loading