Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_snapshot, ec2_snapshot_info: Add support to modify snapshot share permissions #1464

Conversation

mandar242
Copy link
Contributor

SUMMARY
  1. Add support for modifying and resetting snapshot share permissions (createVolumePermissions) of a ec2 snapshot to amazon.aws.ec2_snapshot.
  2. Add ec2 snapshot's snapshot share permissions (createVolumePermissions) to return value of amazon.aws.ec2_snapshot_info.
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

amazon.aws.ec2_snapshot
amazon.aws.ec2_snapshot_info

ADDITIONAL INFORMATION

API references

describe_snapshot_attribute
modify_snapshot_attribute
reset_snapshot_attribute

@github-actions
Copy link

github-actions bot commented Apr 21, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b976d9538a284cb6870fdcf177e38439

✔️ ansible-galaxy-importer SUCCESS in 4m 21s
✔️ build-ansible-collection SUCCESS in 13m 27s
ansible-test-sanity-aws-ansible-python38 FAILURE in 12m 39s (non-voting)
ansible-test-sanity-aws-ansible-2.12-python38 FAILURE in 12m 51s
ansible-test-sanity-aws-ansible-2.13-python38 FAILURE in 12m 47s
ansible-test-sanity-aws-ansible-2.14 FAILURE in 12m 54s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 11m 51s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 10m 42s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 11m 30s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 12m 58s
✔️ cloud-tox-py3 SUCCESS in 7m 29s
ansible-test-changelog FAILURE in 4m 31s
✔️ ansible-test-splitter SUCCESS in 4m 46s
integration-amazon.aws-1 RETRY_LIMIT in 1m 29s
integration-community.aws-1 RETRY_LIMIT in 1m 29s
Skipped 42 jobs

plugins/modules/ec2_snapshot.py Outdated Show resolved Hide resolved
@mandar242 mandar242 force-pushed the reset-snapshot-attribute-dev branch from c71fa35 to 851ce35 Compare April 26, 2023 02:42
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1228a2a814b141d8a8b2f0752510e0fc

✔️ ansible-galaxy-importer SUCCESS in 3m 59s
✔️ build-ansible-collection SUCCESS in 13m 28s
✔️ ansible-test-splitter SUCCESS in 5m 21s
✔️ integration-amazon.aws-1 SUCCESS in 14m 55s
Skipped 43 jobs

@mandar242 mandar242 requested a review from tremble April 26, 2023 06:07
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3f50fff00fd845eb8fe32821e9eef819

✔️ ansible-galaxy-importer SUCCESS in 3m 41s
✔️ build-ansible-collection SUCCESS in 13m 01s
✔️ ansible-test-splitter SUCCESS in 5m 10s
✔️ integration-amazon.aws-1 SUCCESS in 15m 18s
✔️ integration-community.aws-1 SUCCESS in 32m 21s
✔️ integration-community.aws-2 SUCCESS in 23m 36s
✔️ integration-community.aws-3 SUCCESS in 15m 35s
Skipped 40 jobs

plugins/modules/ec2_snapshot.py Outdated Show resolved Hide resolved
plugins/modules/ec2_snapshot.py Show resolved Hide resolved
plugins/modules/ec2_snapshot.py Show resolved Hide resolved
plugins/modules/ec2_snapshot.py Show resolved Hide resolved
plugins/modules/ec2_snapshot.py Show resolved Hide resolved
plugins/modules/ec2_snapshot.py Outdated Show resolved Hide resolved
plugins/modules/ec2_snapshot.py Outdated Show resolved Hide resolved
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/7c8daedb7ecf44f3b9e533429f700bec

✔️ ansible-galaxy-importer SUCCESS in 3m 49s
✔️ build-ansible-collection SUCCESS in 12m 38s
✔️ ansible-test-splitter SUCCESS in 4m 59s
✔️ integration-amazon.aws-1 SUCCESS in 16m 55s
✔️ integration-amazon.aws-2 SUCCESS in 9m 26s
✔️ integration-community.aws-1 SUCCESS in 55m 54s
✔️ integration-community.aws-2 SUCCESS in 22m 31s
✔️ integration-community.aws-3 SUCCESS in 5m 11s
✔️ integration-community.aws-4 SUCCESS in 44m 13s
✔️ integration-community.aws-5 SUCCESS in 48m 17s
✔️ integration-community.aws-6 SUCCESS in 21m 36s
✔️ integration-community.aws-7 SUCCESS in 29m 12s
✔️ integration-community.aws-8 SUCCESS in 26m 02s
integration-community.aws-9 RETRY_LIMIT in 1m 35s
✔️ integration-community.aws-10 SUCCESS in 22m 21s
integration-community.aws-11 RETRY_LIMIT in 1m 33s
integration-community.aws-12 RETRY_LIMIT in 1m 35s
✔️ integration-community.aws-13 SUCCESS in 23m 43s
✔️ integration-community.aws-14 SUCCESS in 43m 06s
✔️ integration-community.aws-15 SUCCESS in 15m 14s
✔️ integration-community.aws-16 SUCCESS in 45m 08s
✔️ integration-community.aws-17 SUCCESS in 8m 47s
✔️ integration-community.aws-18 SUCCESS in 10m 40s
✔️ integration-community.aws-19 SUCCESS in 22m 22s
✔️ integration-community.aws-20 SUCCESS in 11m 25s
Skipped 22 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/1e1ac1c4df9440f98449cc2e497f6cff

✔️ ansible-galaxy-importer SUCCESS in 3m 44s
✔️ build-ansible-collection SUCCESS in 12m 35s
✔️ ansible-test-splitter SUCCESS in 5m 06s
✔️ integration-amazon.aws-1 SUCCESS in 16m 23s
✔️ integration-amazon.aws-2 SUCCESS in 8m 25s
integration-community.aws-1 TIMED_OUT in 1h 00m 42s
✔️ integration-community.aws-2 SUCCESS in 23m 18s
✔️ integration-community.aws-3 SUCCESS in 6m 01s
✔️ integration-community.aws-4 SUCCESS in 37m 16s
✔️ integration-community.aws-5 SUCCESS in 44m 25s
✔️ integration-community.aws-6 SUCCESS in 6m 36s
✔️ integration-community.aws-7 SUCCESS in 27m 19s
✔️ integration-community.aws-8 SUCCESS in 24m 27s
✔️ integration-community.aws-9 SUCCESS in 33m 23s
✔️ integration-community.aws-10 SUCCESS in 24m 07s
✔️ integration-community.aws-11 SUCCESS in 31m 29s
✔️ integration-community.aws-12 SUCCESS in 27m 20s
✔️ integration-community.aws-13 SUCCESS in 23m 22s
✔️ integration-community.aws-14 SUCCESS in 43m 17s
✔️ integration-community.aws-15 SUCCESS in 15m 35s
✔️ integration-community.aws-16 SUCCESS in 42m 24s
✔️ integration-community.aws-17 SUCCESS in 8m 56s
✔️ integration-community.aws-18 SUCCESS in 10m 29s
✔️ integration-community.aws-19 SUCCESS in 20m 47s
✔️ integration-community.aws-20 SUCCESS in 10m 00s
Skipped 22 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/9d8cd8a8c5f14c2f8453b415b5e28443

✔️ ansible-galaxy-importer SUCCESS in 3m 57s
✔️ build-ansible-collection SUCCESS in 13m 43s
✔️ ansible-test-splitter SUCCESS in 5m 28s
✔️ integration-amazon.aws-1 SUCCESS in 14m 22s
Skipped 43 jobs

plugins/modules/ec2_snapshot.py Outdated Show resolved Hide resolved
plugins/modules/ec2_snapshot.py Outdated Show resolved Hide resolved
plugins/modules/ec2_snapshot.py Show resolved Hide resolved
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/6e3ed226e24b405bba6cbd80fc0ada94

✔️ ansible-galaxy-importer SUCCESS in 4m 12s
✔️ build-ansible-collection SUCCESS in 13m 13s
✔️ ansible-test-splitter SUCCESS in 5m 04s
✔️ integration-amazon.aws-1 SUCCESS in 21m 31s
✔️ integration-amazon.aws-2 SUCCESS in 7m 27s
✔️ integration-community.aws-1 SUCCESS in 52m 22s
✔️ integration-community.aws-2 SUCCESS in 23m 40s
✔️ integration-community.aws-3 SUCCESS in 5m 40s
✔️ integration-community.aws-4 SUCCESS in 43m 37s
✔️ integration-community.aws-5 SUCCESS in 45m 33s
✔️ integration-community.aws-6 SUCCESS in 6m 25s
✔️ integration-community.aws-7 SUCCESS in 32m 46s
✔️ integration-community.aws-8 SUCCESS in 22m 00s
✔️ integration-community.aws-9 SUCCESS in 34m 29s
✔️ integration-community.aws-10 SUCCESS in 22m 47s
✔️ integration-community.aws-11 SUCCESS in 32m 02s
✔️ integration-community.aws-12 SUCCESS in 25m 48s
✔️ integration-community.aws-13 SUCCESS in 23m 35s
✔️ integration-community.aws-14 SUCCESS in 41m 14s
✔️ integration-community.aws-15 SUCCESS in 16m 41s
integration-community.aws-16 FAILURE in 38m 28s
✔️ integration-community.aws-17 SUCCESS in 8m 31s
✔️ integration-community.aws-18 SUCCESS in 10m 32s
✔️ integration-community.aws-19 SUCCESS in 21m 53s
✔️ integration-community.aws-20 SUCCESS in 11m 00s
Skipped 22 jobs

@mandar242 mandar242 force-pushed the reset-snapshot-attribute-dev branch from 9614d06 to bac37d7 Compare May 3, 2023 00:01
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/191c946b15a74f72847df38a9fc04d85

✔️ ansible-galaxy-importer SUCCESS in 4m 36s
✔️ build-ansible-collection SUCCESS in 14m 16s
✔️ ansible-test-splitter SUCCESS in 5m 59s
✔️ integration-amazon.aws-1 SUCCESS in 13m 02s
Skipped 43 jobs

@mandar242 mandar242 changed the title [WIP] ec2_snapshot, ec2_snapshot_info: Add support to modify snapshot share permissions ec2_snapshot, ec2_snapshot_info: Add support to modify snapshot share permissions May 3, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/faf662cb5b644b2e8461dd2b80126135

✔️ ansible-galaxy-importer SUCCESS in 4m 02s
✔️ build-ansible-collection SUCCESS in 14m 12s
✔️ ansible-test-splitter SUCCESS in 4m 41s
integration-amazon.aws-1 FAILURE in 7m 40s
Skipped 43 jobs

@alinabuzachis
Copy link
Contributor

@gravesm I'm not sure though, but, is this something we can test in the CI?

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e54d595b7ce44dc192f8fdfb98105388

✔️ ansible-galaxy-importer SUCCESS in 4m 05s
✔️ build-ansible-collection SUCCESS in 12m 47s
✔️ ansible-test-splitter SUCCESS in 5m 05s
✔️ integration-amazon.aws-1 SUCCESS in 17m 29s
Skipped 43 jobs

@mandar242 mandar242 added mergeit Merge the PR (SoftwareFactory) and removed mergeit Merge the PR (SoftwareFactory) labels May 9, 2023
@mandar242 mandar242 requested review from tremble and removed request for tremble May 9, 2023 19:05
@mandar242
Copy link
Contributor Author

regate

@alinabuzachis alinabuzachis added the backport-6 PR should be backported to the stable-6 branch label May 10, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d887b3e4624d4a95b749bafd9dfb97cc

✔️ ansible-galaxy-importer SUCCESS in 3m 58s
✔️ build-ansible-collection SUCCESS in 12m 43s
✔️ ansible-test-splitter SUCCESS in 4m 41s
✔️ integration-amazon.aws-1 SUCCESS in 15m 49s
Skipped 43 jobs

@mandar242
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b8fd2e85b77f49fc86e0b619fed391b3

✔️ ansible-galaxy-importer SUCCESS in 4m 24s
✔️ build-ansible-collection SUCCESS in 13m 13s
✔️ ansible-test-splitter SUCCESS in 4m 42s
✔️ integration-amazon.aws-1 SUCCESS in 15m 48s
Skipped 43 jobs

@alinabuzachis

This comment was marked as outdated.

@jillr jillr dismissed tremble’s stale review May 11, 2023 18:37

Review comment has been addressed in a previous commit

@tremble
Copy link
Contributor

tremble commented May 11, 2023

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/639e53bbe2aa4853a4adada145489df5

✔️ ansible-galaxy-importer SUCCESS in 4m 11s
✔️ build-ansible-collection SUCCESS in 12m 18s
✔️ ansible-test-splitter SUCCESS in 4m 52s
✔️ integration-amazon.aws-1 SUCCESS in 18m 15s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1f1ac75 into ansible-collections:main May 11, 2023
@patchback
Copy link

patchback bot commented May 11, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/1f1ac75a4ac85635359be906d150a75d8a9fbb78/pr-1464

Backported as #1546

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 11, 2023
… permissions (#1464)

ec2_snapshot, ec2_snapshot_info: Add support to modify snapshot share permissions

SUMMARY

Add support for modifying and resetting snapshot share permissions (createVolumePermissions) of a ec2 snapshot to amazon.aws.ec2_snapshot.
Add ec2 snapshot's snapshot share permissions (createVolumePermissions) to return value of amazon.aws.ec2_snapshot_info.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

amazon.aws.ec2_snapshot
amazon.aws.ec2_snapshot_info
ADDITIONAL INFORMATION

API references

describe_snapshot_attribute
modify_snapshot_attribute
reset_snapshot_attribute

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
Reviewed-by: Mike Graves <mgraves@redhat.com>
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
(cherry picked from commit 1f1ac75)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 12, 2023
… permissions (#1464) (#1546)

[PR #1464/1f1ac75a backport][stable-6] ec2_snapshot, ec2_snapshot_info: Add support to modify snapshot share permissions

This is a backport of PR #1464 as merged into main (1f1ac75).
SUMMARY


Add support for modifying and resetting snapshot share permissions (createVolumePermissions) of a ec2 snapshot to amazon.aws.ec2_snapshot.
Add ec2 snapshot's snapshot share permissions (createVolumePermissions) to return value of amazon.aws.ec2_snapshot_info.


ISSUE TYPE


Feature Pull Request

COMPONENT NAME

amazon.aws.ec2_snapshot
amazon.aws.ec2_snapshot_info
ADDITIONAL INFORMATION


API references

describe_snapshot_attribute
modify_snapshot_attribute
reset_snapshot_attribute

Reviewed-by: Mark Chappell
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request May 19, 2023
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 19, 2023
…odify snapshotot share permissions (#1464) (#1546)" (#1560)

Temporarily Revert "ec2_snapshot, ec2_snapshot_info: Add support to modify snapshotot share permissions (#1464) (#1546)"

Temporarily Revert "ec2_snapshot, ec2_snapshot_info: Add support to modify snapshotot share permissions (#1464) (#1546)"
This reverts commit 6698cdd.
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request May 19, 2023
… permissions (ansible-collections#1464)

ec2_snapshot, ec2_snapshot_info: Add support to modify snapshot share permissions

SUMMARY


Add support for modifying and resetting snapshot share permissions (createVolumePermissions) of a ec2 snapshot to amazon.aws.ec2_snapshot.
Add ec2 snapshot's snapshot share permissions (createVolumePermissions) to return value of amazon.aws.ec2_snapshot_info.


ISSUE TYPE


Feature Pull Request

COMPONENT NAME

amazon.aws.ec2_snapshot
amazon.aws.ec2_snapshot_info
ADDITIONAL INFORMATION


API references

describe_snapshot_attribute
modify_snapshot_attribute
reset_snapshot_attribute

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
Reviewed-by: Mike Graves <mgraves@redhat.com>
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 22, 2023
… permissions (#1464) (#1562)

[Manual backport to stable-6] ec2_snapshot, ec2_snapshot_info: Add support to modify snapshot share permissions (#1464)

[Manual backport to stable-6] ec2_snapshot, ec2_snapshot_info: Add support to modify snapshot share permissions (#1464)
SUMMARY
Add support for modifying and resetting snapshot share permissions (createVolumePermissions) of a ec2 snapshot to amazon.aws.ec2_snapshot. Add ec2 snapshot's snapshot share permissions (createVolumePermissions) to return value of amazon.aws.ec2_snapshot_info.
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
amazon.aws.ec2_snapshot
amazon.aws.ec2_snapshot_info
ADDITIONAL INFORMATION
API references
describe_snapshot_attribute
modify_snapshot_attribute
reset_snapshot_attribute
Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
Reviewed-by: Mike Graves mgraves@redhat.com
Reviewed-by: Mandar Kulkarni mandar242@gmail.com
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-6 PR should be backported to the stable-6 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants