Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elbv2 - Drop tests for ancient botocore (not supported) #1477

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Apr 26, 2023

SUMMARY

Remove compat code for old botocore versions.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

module_utils/elbv2

ADDITIONAL INFORMATION

We dropped support for botocore 1.10.30 a couple of years ago.

@tremble tremble marked this pull request as ready for review April 26, 2023 09:14
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/90677cf407404b34be63b4b03493d39c

✔️ ansible-galaxy-importer SUCCESS in 3m 40s
✔️ build-ansible-collection SUCCESS in 12m 32s
✔️ ansible-test-splitter SUCCESS in 4m 48s
✔️ integration-amazon.aws-1 SUCCESS in 9m 55s
✔️ integration-community.aws-1 SUCCESS in 21m 27s
Skipped 42 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Apr 26, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/f7957d79966647589580cf0955cc3538

✔️ ansible-galaxy-importer SUCCESS in 4m 23s
✔️ build-ansible-collection SUCCESS in 12m 59s
✔️ ansible-test-splitter SUCCESS in 4m 53s
✔️ integration-amazon.aws-1 SUCCESS in 8m 19s
✔️ integration-community.aws-1 SUCCESS in 19m 07s
Skipped 42 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 2176fb4 into ansible-collections:main Apr 26, 2023
39 checks passed
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Apr 26, 2023
…1477)

elbv2 - Drop tests for ancient botocore (not supported)

SUMMARY
Remove compat code for old botocore versions.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
module_utils/elbv2
ADDITIONAL INFORMATION
We dropped support for botocore 1.10.30 a couple of years ago.

Reviewed-by: Alina Buzachis
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 26, 2023
[manual backport stable-5] Drop tests for ancient botocore (not supported) (#1477)

elbv2 - Drop tests for ancient botocore (not supported)
SUMMARY
Remove compat code for old botocore versions.
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
module_utils/elbv2
ADDITIONAL INFORMATION
We dropped support for botocore 1.10.30 a couple of years ago.
Reviewed-by: Alina Buzachis
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…nsible-collections#1477)

ec2_placement_group: Handle a potential race creation during create

Address a race condition during the creation of a new Placement Group.
The consequence was a "placement_group": null in output after a
successful new creation.
e.g: https://af0ac3e5f4e1620a8d63-ed3785e7f94a59162d05eede0959ab4b.ssl.cf5.rackcdn.com/1459/71e1a28c8ab7c12471b7f1cce5a37846ff642439/check/integration-community.aws-12/aa426fe/job-output.txt

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…nsible-collections#1477)

ec2_placement_group: Handle a potential race creation during create

Address a race condition during the creation of a new Placement Group.
The consequence was a "placement_group": null in output after a
successful new creation.
e.g: https://af0ac3e5f4e1620a8d63-ed3785e7f94a59162d05eede0959ab4b.ssl.cf5.rackcdn.com/1459/71e1a28c8ab7c12471b7f1cce5a37846ff642439/check/integration-community.aws-12/aa426fe/job-output.txt

Reviewed-by: Mark Chappell <None>
@tremble tremble deleted the elbv2/old-botocore branch September 27, 2023 07:00
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…nsible-collections#1477)

ec2_placement_group: Handle a potential race creation during create

Address a race condition during the creation of a new Placement Group.
The consequence was a "placement_group": null in output after a
successful new creation.
e.g: https://af0ac3e5f4e1620a8d63-ed3785e7f94a59162d05eede0959ab4b.ssl.cf5.rackcdn.com/1459/71e1a28c8ab7c12471b7f1cce5a37846ff642439/check/integration-community.aws-12/aa426fe/job-output.txt

Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants