s3_bucket - Ensure public_access settings are configured before policies #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinabuzachis
approved these changes
May 4, 2023
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 44s |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 44s |
softwarefactory-project-zuul
bot
merged commit f14f3ee
into
ansible-collections:main
39 checks passed
tremble
added a commit
to tremble/amazon.aws
that referenced
this pull request
May 4, 2023
…ies (ansible-collections#1511) s3_bucket - Ensure public_access settings are configured before policies SUMMARY At the end of April Amazon updated various S3 bucket defaults. Buckets now have public_access blocked by default, and object_owner set to "BucketOwnerEnforced". https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/ This uncovered a race condition where we set the policy before setting the public_access configs. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_bucket ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 4, 2023
…ies (#1511) (#1512) [stable-5] [backport/1511] s3_bucket - Ensure public_access settings are configured before policies Manual backport of #1511 SUMMARY At the end of April Amazon updated various S3 bucket defaults. Buckets now have public_access blocked by default, and object_owner set to "BucketOwnerEnforced". https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/ This uncovered a race condition where we set the policy before setting the public_access configs ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_bucket ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
May 4, 2023
Fix s3_sync and s3_logging integration tests SUMMARY See also: ansible-collections/amazon.aws#1511 At the end of April Amazon updated various S3 bucket defaults. Buckets now have public_access blocked by default, and object_owner set to "BucketOwnerEnforced". https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/ This change to the defaults resulted in some of our tests failing. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_sync s3_logging ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
patchback bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
May 4, 2023
Fix s3_sync and s3_logging integration tests SUMMARY See also: ansible-collections/amazon.aws#1511 At the end of April Amazon updated various S3 bucket defaults. Buckets now have public_access blocked by default, and object_owner set to "BucketOwnerEnforced". https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/ This change to the defaults resulted in some of our tests failing. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_sync s3_logging ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis (cherry picked from commit 4cad9ee)
tremble
added a commit
to ansible-collections/community.aws
that referenced
this pull request
May 4, 2023
Fix s3_sync and s3_logging integration tests SUMMARY See also: ansible-collections/amazon.aws#1511 At the end of April Amazon updated various S3 bucket defaults. Buckets now have public_access blocked by default, and object_owner set to "BucketOwnerEnforced". https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/ This change to the defaults resulted in some of our tests failing. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_sync s3_logging ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis (cherry picked from commit 4cad9ee) Co-authored-by: Mark Chappell <mchappel@redhat.com>
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
At the end of April Amazon updated various S3 bucket defaults. Buckets now have public_access blocked by default, and object_owner set to "BucketOwnerEnforced".
https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/
This uncovered a race condition where we set the policy before setting the public_access configs.
ISSUE TYPE
COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION