Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_ec2 inventory - migration to Python 3.6 f-strings #1526

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 7, 2023

SUMMARY

We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup

A combination of

  • black --preview
  • flynt
  • some manual cleanup
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/inventory/aws_ec2.py

ADDITIONAL INFORMATION

We've dropped support for Python <3.6, bulk migrate to fstrings and perform some general string cleanup

A combination of
* `black --preview`
* `flynt`
* some manual cleanup
@tremble tremble changed the title Fstring cleanup aws_ec2 inventory - migration to Python 3.6 f-strings May 7, 2023
@softwarefactory-project-zuul

This comment was marked as resolved.

@tremble tremble marked this pull request as ready for review May 7, 2023 11:47
@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c173327a55934db183a27343a2a24731

✔️ ansible-galaxy-importer SUCCESS in 4m 10s
✔️ build-ansible-collection SUCCESS in 12m 53s
✔️ ansible-test-splitter SUCCESS in 4m 40s
✔️ integration-amazon.aws-1 SUCCESS in 23m 46s
✔️ integration-amazon.aws-2 SUCCESS in 6m 19s
Skipped 42 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 8, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/14e27c6b78a74b8f90eacaf48f811409

✔️ ansible-galaxy-importer SUCCESS in 3m 38s
✔️ build-ansible-collection SUCCESS in 12m 39s
✔️ ansible-test-splitter SUCCESS in 4m 43s
✔️ integration-amazon.aws-1 SUCCESS in 16m 07s
✔️ integration-amazon.aws-2 SUCCESS in 6m 13s
Skipped 42 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7b4c201 into ansible-collections:main May 8, 2023
@tremble tremble deleted the fstring/inv branch September 27, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants