ec2_instance_info - add support for include_attributes #1577
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
abikouo
force-pushed
the
ec2_instance_info_v1
branch
from
027d7a5
to
0ca75a2
Compare
|
recheck |
ansibullbot
added
community_review
feature
abikouo
force-pushed
the
ec2_instance_info_v1
branch
from
0ca75a2
to
30d1e0f
Compare
| ec2_instance_info: | ||
| filters: | ||
| "tag:Name": "{{ ec2_instance_name }}" | ||
| include_attributes: |
There was a problem hiding this comment.
I think we should include all the attribute choices in the test to verify that they all work as expected (I'm seeing that the boto3 docs include enaSupport as an option and also say Note: The enaSupport attribute is not supported at this time. which is...confusing).
There was a problem hiding this comment.
This is like you want to test the AWS API, this is not the scope of ansible.
I can removed enaSupport for now as it is not supported now
There was a problem hiding this comment.
Not really. It's ensuring that the choices we include in our ansible module parameters are correct and are passed correctly to boto3. I have already seen examples in other modules where we assume that this is the case and it is in fact not, but we didn't realize it because we don't test every option in the spec.
There was a problem hiding this comment.
I will remove the choices and use the module the same way we are doing for our info modules as this may changes with new values with new boto3 release
There was a problem hiding this comment.
@hakbailey I have update the tests as required, hope it is ok now
|
recheck |
…rt yet (boto3 1.28.2)
abikouo
force-pushed
the
ec2_instance_info_v1
branch
from
bd74247
to
554318f
Compare
|
regate |
softwarefactory-project-zuul
bot
merged commit ab9b074
into
ansible-collections:main
SUMMARY
include_attributesallows the module to describe specific attributes for an EC2 instanceISSUE TYPE
COMPONENT NAME
ec2_instance_info