Backup vault tag bugfix #1610
Backup vault tag bugfix #1610
Conversation
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 06s |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 16s |
I did, see the new integration task in the initial commit. Is there more I should add? |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 31s |
Co-authored-by: Alina Buzachis <abuzachis@redhat.com>
hakbailey
force-pushed
the
backup-vault-tag-bugfix
branch
from
06e0a6e
to
512ee9c
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 23s |
alinabuzachis
added
the
backport-6
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 02s |
softwarefactory-project-zuul
bot
merged commit 20a8aba
into
ansible-collections:main
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #1624 🤖 @patchback |
Backup vault tag bugfix SUMMARY Fixes an error raised in backup_vault when updating tags on an existing vault by calling the correct boto3 client methods for tagging and untagging a resource. This is not applicable when creating a vault as tags are included in the create_backup_vault method params, but when updating a vault we have to call the tag methods individually. ISSUE TYPE Bugfix Pull Request COMPONENT NAME backup_vault ADDITIONAL INFORMATION See the included new integration test task for a command that previously failed and works with the updated code. Reviewed-by: Alina Buzachis Reviewed-by: Helen Bailey <hebailey@redhat.com> Reviewed-by: Mike Graves <mgraves@redhat.com> (cherry picked from commit 20a8aba)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
[PR #1610/20a8aba8 backport][stable-6] Backup vault tag bugfix This is a backport of PR #1610 as merged into main (20a8aba). SUMMARY Fixes an error raised in backup_vault when updating tags on an existing vault by calling the correct boto3 client methods for tagging and untagging a resource. This is not applicable when creating a vault as tags are included in the create_backup_vault method params, but when updating a vault we have to call the tag methods individually. ISSUE TYPE Bugfix Pull Request COMPONENT NAME backup_vault ADDITIONAL INFORMATION See the included new integration test task for a command that previously failed and works with the updated code. Reviewed-by: Jill R Reviewed-by: Bikouo Aubin
…ons#1610) ecs_taskdefinition - add health check documentation SUMMARY Adds documentation for the healthCheck dict for ecs_taskdefinition. Fixes ansible-collections#1565 ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/ecs_taskdefinition.py ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None>
…ons#1610) ecs_taskdefinition - add health check documentation SUMMARY Adds documentation for the healthCheck dict for ecs_taskdefinition. Fixes ansible-collections#1565 ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/ecs_taskdefinition.py ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None>
…ons#1610) ecs_taskdefinition - add health check documentation SUMMARY Adds documentation for the healthCheck dict for ecs_taskdefinition. Fixes ansible-collections#1565 ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/ecs_taskdefinition.py ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None>
SUMMARY
Fixes an error raised in
backup_vaultwhen updating tags on an existing vault by calling the correct boto3 client methods for tagging and untagging a resource. This is not applicable when creating a vault as tags are included in thecreate_backup_vaultmethod params, but when updating a vault we have to call the tag methods individually.ISSUE TYPE
COMPONENT NAME
backup_vaultADDITIONAL INFORMATION
See the included new integration test task for a command that previously failed and works with the updated code.