Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup vault tag bugfix #1610

Conversation

hakbailey
Copy link
Contributor

SUMMARY

Fixes an error raised in backup_vault when updating tags on an existing vault by calling the correct boto3 client methods for tagging and untagging a resource. This is not applicable when creating a vault as tags are included in the create_backup_vault method params, but when updating a vault we have to call the tag methods individually.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

backup_vault

ADDITIONAL INFORMATION

See the included new integration test task for a command that previously failed and works with the updated code.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/33e4743e9e2441578f0dd61bed63bee7

✔️ ansible-galaxy-importer SUCCESS in 4m 06s
✔️ build-ansible-collection SUCCESS in 14m 56s
✔️ ansible-test-splitter SUCCESS in 5m 08s
✔️ integration-amazon.aws-1 SUCCESS in 7m 53s
integration-amazon.aws-2 FAILURE in 9m 39s
✔️ integration-amazon.aws-3 SUCCESS in 9m 10s
✔️ integration-amazon.aws-4 SUCCESS in 8m 29s
Skipped 40 jobs

@hakbailey
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/fe5393285d7047118ce0f7b38104e0ff

✔️ ansible-galaxy-importer SUCCESS in 4m 16s
✔️ build-ansible-collection SUCCESS in 16m 26s
✔️ ansible-test-splitter SUCCESS in 5m 17s
✔️ integration-amazon.aws-1 SUCCESS in 7m 47s
✔️ integration-amazon.aws-2 SUCCESS in 7m 53s
✔️ integration-amazon.aws-3 SUCCESS in 7m 49s
✔️ integration-amazon.aws-4 SUCCESS in 7m 28s
Skipped 40 jobs

Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some integration tests for this change? Thank you.

@hakbailey
Copy link
Contributor Author

hakbailey commented Jun 13, 2023

Can you please add some integration tests for this change? Thank you.

I did, see the new integration task in the initial commit. Is there more I should add?

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/415590f649a24116a0580d0433a6535f

✔️ ansible-galaxy-importer SUCCESS in 4m 31s
✔️ build-ansible-collection SUCCESS in 13m 40s
✔️ ansible-test-splitter SUCCESS in 4m 52s
✔️ integration-amazon.aws-1 SUCCESS in 5m 45s
✔️ integration-amazon.aws-2 SUCCESS in 6m 46s
✔️ integration-amazon.aws-3 SUCCESS in 5m 42s
✔️ integration-amazon.aws-4 SUCCESS in 5m 46s
Skipped 40 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d0d5c23c8e2449a4b1af5e3d649bb050

✔️ ansible-galaxy-importer SUCCESS in 4m 23s
✔️ build-ansible-collection SUCCESS in 14m 24s
✔️ ansible-test-splitter SUCCESS in 6m 16s
✔️ integration-amazon.aws-1 SUCCESS in 7m 15s
✔️ integration-amazon.aws-2 SUCCESS in 7m 14s
✔️ integration-amazon.aws-3 SUCCESS in 7m 49s
✔️ integration-amazon.aws-4 SUCCESS in 6m 44s
Skipped 40 jobs

@alinabuzachis alinabuzachis added the backport-6 PR should be backported to the stable-6 branch label Jun 27, 2023
@hakbailey hakbailey added the mergeit Merge the PR (SoftwareFactory) label Jun 27, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/225d0011012b4f658f8804e6f82c664a

✔️ ansible-galaxy-importer SUCCESS in 4m 02s
✔️ build-ansible-collection SUCCESS in 13m 00s
✔️ ansible-test-splitter SUCCESS in 5m 29s
✔️ integration-amazon.aws-1 SUCCESS in 5m 55s
✔️ integration-amazon.aws-2 SUCCESS in 8m 04s
✔️ integration-amazon.aws-3 SUCCESS in 5m 45s
✔️ integration-amazon.aws-4 SUCCESS in 8m 36s
Skipped 40 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 20a8aba into ansible-collections:main Jun 27, 2023
106 checks passed
@patchback
Copy link

patchback bot commented Jun 27, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/20a8aba8d6961da25cc7df87a8c9b424a9ed670c/pr-1610

Backported as #1624

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 27, 2023
Backup vault tag bugfix

SUMMARY
Fixes an error raised in backup_vault when updating tags on an existing vault by calling the correct boto3 client methods for tagging and untagging a resource. This is not applicable when creating a vault as tags are included in the create_backup_vault method params, but when updating a vault we have to call the tag methods individually.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
backup_vault
ADDITIONAL INFORMATION
See the included new integration test task for a command that previously failed and works with the updated code.

Reviewed-by: Alina Buzachis
Reviewed-by: Helen Bailey <hebailey@redhat.com>
Reviewed-by: Mike Graves <mgraves@redhat.com>
(cherry picked from commit 20a8aba)
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@hakbailey hakbailey deleted the backup-vault-tag-bugfix branch June 27, 2023 19:50
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 3, 2023
[PR #1610/20a8aba8 backport][stable-6] Backup vault tag bugfix

This is a backport of PR #1610 as merged into main (20a8aba).
SUMMARY
Fixes an error raised in backup_vault when updating tags on an existing vault by calling the correct boto3 client methods for tagging and untagging a resource. This is not applicable when creating a vault as tags are included in the create_backup_vault method params, but when updating a vault we have to call the tag methods individually.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
backup_vault
ADDITIONAL INFORMATION
See the included new integration test task for a command that previously failed and works with the updated code.

Reviewed-by: Jill R
Reviewed-by: Bikouo Aubin
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…ons#1610)

ecs_taskdefinition - add health check documentation

SUMMARY

Adds documentation for the healthCheck dict for ecs_taskdefinition.

Fixes ansible-collections#1565
ISSUE TYPE


Docs Pull Request

COMPONENT NAME

plugins/modules/ecs_taskdefinition.py
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…ons#1610)

ecs_taskdefinition - add health check documentation

SUMMARY

Adds documentation for the healthCheck dict for ecs_taskdefinition.

Fixes ansible-collections#1565
ISSUE TYPE


Docs Pull Request

COMPONENT NAME

plugins/modules/ecs_taskdefinition.py
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…ons#1610)

ecs_taskdefinition - add health check documentation

SUMMARY

Adds documentation for the healthCheck dict for ecs_taskdefinition.

Fixes ansible-collections#1565
ISSUE TYPE


Docs Pull Request

COMPONENT NAME

plugins/modules/ecs_taskdefinition.py
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-6 PR should be backported to the stable-6 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants