ec2_instance: add AWSRetry.jittered_backoff on client.describe_instance_attribute #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
hakbailey
requested changes
Jul 24, 2023
There was a problem hiding this comment.
@tchernomax thank you for submitting this! The PR looks good but it needs a changelog fragment, would you be able to add that?
done |
hakbailey
reviewed
Aug 22, 2023
alinabuzachis
approved these changes
Sep 1, 2023
alinabuzachis
added
backport-5
hakbailey
approved these changes
Sep 1, 2023
|
recheck |
|
any news ? |
|
recheck |
|
@gravesm it seems it fail at a different test at each run. |
tremble
requested changes
Sep 19, 2023
tremble
approved these changes
Oct 20, 2023
…fix InvalidInstanceID.NotFound)
… trigger a retry (catch_extra_error_codes)
… trigger a retry (catch_extra_error_codes)
… trigger a retry (catch_extra_error_codes)
tremble
force-pushed
the
InvalidInstanceID_NotFound
branch
from
b0f124b
to
a9854c3
Compare
|
Thanks for submitting this PR. I'm sorry it's taken so long to get this merged. |
softwarefactory-project-zuul
bot
merged commit ead8302
into
ansible-collections:main
35 of 65 checks passed
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #1817 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
…ce_attribute (#1650) ec2_instance: add AWSRetry.jittered_backoff on client.describe_instance_attribute SUMMARY try to fix InvalidInstanceID.NotFound Could not describe attribute groupSet for instance i-…: An error occurred (InvalidInstanceID.NotFound) when calling the DescribeInstanceAttribute operation: The instance ID 'i-…' does not exist The instance actually exists, it's just an API problem. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance Reviewed-by: Helen Bailey <hebailey@redhat.com> Reviewed-by: Alina Buzachis Reviewed-by: tchernomax Reviewed-by: Mark Chappell (cherry picked from commit ead8302)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
…ce_attribute (#1650) (#1817) [PR #1650/ead83029 backport][stable-6] ec2_instance: add AWSRetry.jittered_backoff on client.describe_instance_attribute This is a backport of PR #1650 as merged into main (ead8302). SUMMARY try to fix InvalidInstanceID.NotFound Could not describe attribute groupSet for instance i-…: An error occurred (InvalidInstanceID.NotFound) when calling the DescribeInstanceAttribute operation: The instance ID 'i-…' does not exist The instance actually exists, it's just an API problem. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
try to fix InvalidInstanceID.NotFound
The instance actually exists, it's just an API problem.
ISSUE TYPE
COMPONENT NAME
ec2_instance