rds_cluster - enable creation or modification of AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and EngineMode #1657

alinabuzachis · 2023-07-13T10:16:24Z

SUMMARY

Add AllocatedStorage, DBClusterInstanceClass, StorageType, Iops and EngineMode to the list of parameters that can be passed when creating or modifying a Multi-AZ RDS cluster.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

rds_cluster

ansibullbot · 2023-07-13T10:40:35Z

cc @jillr @s-hertel @tremble
click here for bot help

softwarefactory-project-zuul · 2023-07-13T10:48:41Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/fc17cce6513c4c6c826f6774781cb8a2

✔️ ansible-galaxy-importer SUCCESS in 4m 21s
✔️ build-ansible-collection SUCCESS in 12m 29s
✔️ ansible-test-splitter SUCCESS in 5m 04s
✔️ integration-amazon.aws-1 SUCCESS in 7m 50s
✔️ integration-amazon.aws-2 SUCCESS in 10m 59s
✔️ integration-amazon.aws-3 SUCCESS in 10m 40s
✔️ integration-amazon.aws-4 SUCCESS in 17m 50s
✔️ integration-amazon.aws-5 SUCCESS in 8m 18s
Skipped 39 jobs

ansibullbot · 2023-07-21T14:59:31Z

@alinabuzachis this PR contains the following merge commits:

6324023

Please rebase your branch to remove these commits.

click here for bot help

softwarefactory-project-zuul · 2023-07-21T15:15:28Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/95577da08c414981b87d57e67ec23d25

✔️ ansible-galaxy-importer SUCCESS in 4m 12s
✔️ build-ansible-collection SUCCESS in 14m 19s
✔️ ansible-test-splitter SUCCESS in 4m 57s
✔️ integration-amazon.aws-1 SUCCESS in 10m 30s
✔️ integration-amazon.aws-2 SUCCESS in 11m 32s
✔️ integration-amazon.aws-3 SUCCESS in 10m 47s
✔️ integration-amazon.aws-4 SUCCESS in 17m 46s
✔️ integration-amazon.aws-5 SUCCESS in 10m 42s
Skipped 39 jobs

ansibullbot · 2023-07-26T09:01:39Z

@alinabuzachis this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

softwarefactory-project-zuul · 2023-07-26T09:33:44Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/60c5227b5f534f5cb660e393241d614b

✔️ ansible-galaxy-importer SUCCESS in 4m 37s
✔️ build-ansible-collection SUCCESS in 13m 33s
✔️ ansible-test-splitter SUCCESS in 5m 15s
✔️ integration-amazon.aws-1 SUCCESS in 13m 58s
✔️ integration-amazon.aws-2 SUCCESS in 13m 21s
✔️ integration-amazon.aws-3 SUCCESS in 19m 40s
✔️ integration-amazon.aws-4 SUCCESS in 23m 40s
✔️ integration-amazon.aws-5 SUCCESS in 10m 24s
Skipped 39 jobs

…EngineMode to the list of parameters that can be passed when creating or modifying a Multi-AZ RDS cluster. Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

softwarefactory-project-zuul · 2023-07-26T12:29:00Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4b745670cfe44bcb9ff6b1ad4d8f2010

✔️ ansible-galaxy-importer SUCCESS in 4m 45s
✔️ build-ansible-collection SUCCESS in 15m 44s
✔️ ansible-test-splitter SUCCESS in 4m 48s
✔️ integration-amazon.aws-1 SUCCESS in 9m 51s
✔️ integration-amazon.aws-2 SUCCESS in 9m 27s
✔️ integration-amazon.aws-3 SUCCESS in 10m 14s
✔️ integration-amazon.aws-4 SUCCESS in 18m 30s
✔️ integration-amazon.aws-5 SUCCESS in 7m 16s
Skipped 39 jobs

softwarefactory-project-zuul · 2023-07-31T12:05:32Z

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/3af7af829a014c08a7d9ef007a954ad1

✔️ ansible-galaxy-importer SUCCESS in 5m 02s
✔️ build-ansible-collection SUCCESS in 12m 44s
✔️ ansible-test-splitter SUCCESS in 4m 50s
✔️ integration-amazon.aws-1 SUCCESS in 10m 07s
✔️ integration-amazon.aws-2 SUCCESS in 12m 22s
✔️ integration-amazon.aws-3 SUCCESS in 10m 05s
✔️ integration-amazon.aws-4 SUCCESS in 16m 43s
✔️ integration-amazon.aws-5 SUCCESS in 10m 39s
Skipped 39 jobs

patchback · 2023-07-31T12:05:37Z

Backport to stable-5: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 70aafdd on top of patchback/backports/stable-5/70aafdd9ab53fede7d948c89382125e98aa1bc11/pr-1657

Backporting merged PR #1657 into main

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-5/70aafdd9ab53fede7d948c89382125e98aa1bc11/pr-1657 upstream/stable-5

Now, cherry-pick PR rds_cluster - enable creation or modification of AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and EngineMode #1657 contents into that branch:
```
$ git cherry-pick -x 70aafdd9ab53fede7d948c89382125e98aa1bc11
```
If it'll yell at you with something like fatal: Commit 70aafdd9ab53fede7d948c89382125e98aa1bc11 is a merge but no -m option was given., add -m 1 as follows instead:
```
$ git cherry-pick -m1 -x 70aafdd9ab53fede7d948c89382125e98aa1bc11
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR rds_cluster - enable creation or modification of AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and EngineMode #1657 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-5/70aafdd9ab53fede7d948c89382125e98aa1bc11/pr-1657

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback · 2023-07-31T12:05:44Z

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/70aafdd9ab53fede7d948c89382125e98aa1bc11/pr-1657

Backported as #1674

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

…EngineMode to the list of parameters that can be passed when creating or modifying a Multi-AZ RDS cluster. (#1657) rds_cluster - enable creation or modification of AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and EngineMode SUMMARY Add AllocatedStorage, DBClusterInstanceClass, StorageType, Iops and EngineMode to the list of parameters that can be passed when creating or modifying a Multi-AZ RDS cluster. ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_cluster Reviewed-by: Taeho Park Reviewed-by: Mike Graves <mgraves@redhat.com> (cherry picked from commit 70aafdd)

…EngineMode to the list of parameters that can be passed when creating or modifying a Multi-AZ RDS cluster. (ansible-collections#1657) rds_cluster - enable creation or modification of AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and EngineMode SUMMARY Add AllocatedStorage, DBClusterInstanceClass, StorageType, Iops and EngineMode to the list of parameters that can be passed when creating or modifying a Multi-AZ RDS cluster. ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_cluster Reviewed-by: Taeho Park Reviewed-by: Mike Graves <mgraves@redhat.com> (cherry picked from commit 70aafdd)

…EngineMode to the list of parameters that can be passed when creating or modifying a Multi-AZ RDS cluster. (#1657) (#1674) [PR #1657/70aafdd9 backport][stable-6] rds_cluster - enable creation or modification of AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and EngineMode This is a backport of PR #1657 as merged into main (70aafdd). SUMMARY Add AllocatedStorage, DBClusterInstanceClass, StorageType, Iops and EngineMode to the list of parameters that can be passed when creating or modifying a Multi-AZ RDS cluster. ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_cluster Reviewed-by: Alina Buzachis

…EngineMode to the list of parameters that can be passed when creating or modifying a Multi-AZ RDS cluster. (#1657) (#1677) [backport stable-5] rds_cluster - Add AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and EngineMode Add AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and EngineMode to the list of parameters that can be passed when creating or modifying a Multi-AZ RDS cluster. (#1657) rds_cluster - enable creation or modification of AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and EngineMode SUMMARY Add AllocatedStorage, DBClusterInstanceClass, StorageType, Iops and EngineMode to the list of parameters that can be passed when creating or modifying a Multi-AZ RDS cluster. ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_cluster Reviewed-by: Taeho Park Reviewed-by: Mike Graves mgraves@redhat.com (cherry picked from commit 70aafdd) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mike Graves <mgraves@redhat.com>

…EngineMode to the list of parameters that can be passed when creating or modifying a Multi-AZ RDS cluster. (ansible-collections#1657) rds_cluster - enable creation or modification of AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and EngineMode SUMMARY Add AllocatedStorage, DBClusterInstanceClass, StorageType, Iops and EngineMode to the list of parameters that can be passed when creating or modifying a Multi-AZ RDS cluster. ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_cluster Reviewed-by: Taeho Park Reviewed-by: Mike Graves <mgraves@redhat.com>

SSM connection plugin - Add encryption tests Depends-On: ansible/ansible-zuul-jobs#1746 SUMMARY Expand on the aws_ssm connection integration tests Follow up on suggestion to use ssm_parameter to locate AMIs Add tests for connection using encrypted buckets ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION

alinabuzachis force-pushed the fix_rds_params_passage branch from 99db06a to c327674 Compare July 13, 2023 10:17

alinabuzachis added backport-5 PR should be backported to the stable-5 branch backport-6 PR should be backported to the stable-6 branch labels Jul 13, 2023

ansibullbot added bug This issue/PR relates to a bug community_review module module owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jul 13, 2023

taehopark32 approved these changes Jul 13, 2023

View reviewed changes

ansibullbot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed community_review labels Jul 21, 2023

ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jul 26, 2023

Add AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and …

34ef47d

…EngineMode to the list of parameters that can be passed when creating or modifying a Multi-AZ RDS cluster. Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

alinabuzachis force-pushed the fix_rds_params_passage branch from 67da6c7 to 34ef47d Compare July 26, 2023 11:53

hakbailey modified the milestones: 5.5.3, 6.3.0 Jul 27, 2023

gravesm approved these changes Jul 28, 2023

View reviewed changes

alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Jul 31, 2023

softwarefactory-project-zuul bot merged commit 70aafdd into ansible-collections:main Jul 31, 2023
82 of 85 checks passed

patchback bot mentioned this pull request Jul 31, 2023

[PR #1657/70aafdd9 backport][stable-6] rds_cluster - enable creation or modification of AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and EngineMode #1674

Merged

alinabuzachis mentioned this pull request Aug 1, 2023

[backport stable-5] rds_cluster - Add AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and EngineMode #1677

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rds_cluster - enable creation or modification of AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and EngineMode #1657

rds_cluster - enable creation or modification of AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and EngineMode #1657

alinabuzachis commented Jul 13, 2023

ansibullbot commented Jul 13, 2023

softwarefactory-project-zuul bot commented Jul 13, 2023

ansibullbot commented Jul 21, 2023

softwarefactory-project-zuul bot commented Jul 21, 2023

ansibullbot commented Jul 26, 2023

softwarefactory-project-zuul bot commented Jul 26, 2023

softwarefactory-project-zuul bot commented Jul 26, 2023

softwarefactory-project-zuul bot commented Jul 31, 2023

patchback bot commented Jul 31, 2023 •

edited

Loading

patchback bot commented Jul 31, 2023 •

edited

Loading

rds_cluster - enable creation or modification of AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and EngineMode #1657

rds_cluster - enable creation or modification of AllocatedStorage, DBClusterInstanceClass, StorageType, Iops, and EngineMode #1657

Conversation

alinabuzachis commented Jul 13, 2023

SUMMARY

ISSUE TYPE

COMPONENT NAME

ansibullbot commented Jul 13, 2023

softwarefactory-project-zuul bot commented Jul 13, 2023

ansibullbot commented Jul 21, 2023

softwarefactory-project-zuul bot commented Jul 21, 2023

ansibullbot commented Jul 26, 2023

softwarefactory-project-zuul bot commented Jul 26, 2023

softwarefactory-project-zuul bot commented Jul 26, 2023

softwarefactory-project-zuul bot commented Jul 31, 2023

patchback bot commented Jul 31, 2023 • edited Loading

Backport to stable-5: 💔 cherry-picking failed — conflicts found

Backporting merged PR #1657 into main

patchback bot commented Jul 31, 2023 • edited Loading

Backport to stable-6: 💚 backport PR created

patchback bot commented Jul 31, 2023 •

edited

Loading

patchback bot commented Jul 31, 2023 •

edited

Loading