Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route53: add wait_id return value in case of changes #1683

Conversation

felixfontein
Copy link
Contributor

SUMMARY

This allows to wait for changes later on when wait=false is provided to the module.

Will be needed for a new route53_wait module I'll create a PR for soon in community.aws :)

(I'm not sure whether another 5.x.0 feature release is planned; in case it is not I'll update version_added and the backport-5 label needs to be removed.)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

route53

@felixfontein felixfontein added backport-5 PR should be backported to the stable-5 branch backport-6 PR should be backported to the stable-6 branch labels Aug 2, 2023
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) tests tests labels Aug 2, 2023
@felixfontein
Copy link
Contributor Author

(Documentation of API result: https://docs.aws.amazon.com/Route53/latest/APIReference/API_ChangeInfo.html → shows that wait_id should be a string.)

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/9e17f760baa14123bde920d663af7040

✔️ ansible-galaxy-importer SUCCESS in 4m 32s
✔️ build-ansible-collection SUCCESS in 13m 02s
✔️ ansible-test-splitter SUCCESS in 4m 58s
✔️ integration-amazon.aws-1 SUCCESS in 8m 40s
Skipped 43 jobs

@tremble
Copy link
Contributor

tremble commented Aug 2, 2023

5.6.0 isn't currently planned (not written off, but not planned)

@felixfontein felixfontein removed the backport-5 PR should be backported to the stable-5 branch label Aug 2, 2023
@felixfontein
Copy link
Contributor Author

A corresponding route53_wait module that uses this return value can be found in ansible-collections/community.aws#1904.

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/357544ac44f84efb8bbd68feef81a651

✔️ ansible-galaxy-importer SUCCESS in 5m 35s
✔️ build-ansible-collection SUCCESS in 15m 41s
✔️ ansible-test-splitter SUCCESS in 5m 16s
✔️ integration-amazon.aws-1 SUCCESS in 8m 23s
✔️ integration-community.aws-1 SUCCESS in 30m 40s
✔️ integration-community.aws-2 SUCCESS in 21m 18s
✔️ integration-community.aws-3 SUCCESS in 49m 37s
✔️ integration-community.aws-4 SUCCESS in 53m 32s
✔️ integration-community.aws-5 SUCCESS in 21m 58s
✔️ integration-community.aws-6 SUCCESS in 24m 29s
✔️ integration-community.aws-7 SUCCESS in 35m 48s
✔️ integration-community.aws-8 SUCCESS in 29m 42s
✔️ integration-community.aws-9 SUCCESS in 25m 49s
✔️ integration-community.aws-10 SUCCESS in 28m 52s
✔️ integration-community.aws-11 SUCCESS in 39m 49s
✔️ integration-community.aws-12 SUCCESS in 14m 56s
✔️ integration-community.aws-13 SUCCESS in 22m 48s
✔️ integration-community.aws-14 SUCCESS in 33m 58s
✔️ integration-community.aws-15 SUCCESS in 17m 09s
✔️ integration-community.aws-16 SUCCESS in 46m 09s
✔️ integration-community.aws-17 SUCCESS in 15m 31s
✔️ integration-community.aws-18 SUCCESS in 22m 33s
✔️ integration-community.aws-19 SUCCESS in 12m 44s
Skipped 24 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/e98ce41deb1b424882196fb2b8b51251

✔️ ansible-galaxy-importer SUCCESS in 3m 50s
✔️ build-ansible-collection SUCCESS in 15m 23s
✔️ ansible-test-splitter SUCCESS in 5m 35s
✔️ integration-amazon.aws-1 SUCCESS in 8m 13s
Skipped 43 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4517e63978144c8cb9f99c03ffbf5a2e

✔️ ansible-galaxy-importer SUCCESS in 4m 32s
✔️ build-ansible-collection SUCCESS in 13m 43s
✔️ ansible-test-splitter SUCCESS in 5m 23s
✔️ integration-amazon.aws-1 SUCCESS in 9m 51s
Skipped 43 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/6741f14094114677ba2454f02847f6c1

✔️ ansible-galaxy-importer SUCCESS in 4m 46s
✔️ build-ansible-collection SUCCESS in 12m 59s
✔️ ansible-test-splitter SUCCESS in 4m 46s
integration-amazon.aws-1 RETRY_LIMIT in 1m 36s
Skipped 43 jobs

@tremble
Copy link
Contributor

tremble commented Aug 2, 2023

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/49e90518a8f64b3aa9216de86a2812fc

✔️ ansible-galaxy-importer SUCCESS in 5m 03s
✔️ build-ansible-collection SUCCESS in 12m 49s
✔️ ansible-test-splitter SUCCESS in 5m 22s
✔️ integration-amazon.aws-1 SUCCESS in 9m 57s
Skipped 43 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Required status check "ansible/check" is expected.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d65d0f3f18aa4362bd2705fb52e227a0

✔️ ansible-galaxy-importer SUCCESS in 4m 58s
✔️ build-ansible-collection SUCCESS in 13m 22s
✔️ ansible-test-splitter SUCCESS in 5m 08s
✔️ integration-amazon.aws-1 SUCCESS in 8m 31s
Skipped 43 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/21ba4c5f183e48debf3fa93b2d208c75

✔️ ansible-galaxy-importer SUCCESS in 4m 07s
✔️ build-ansible-collection SUCCESS in 13m 45s
✔️ ansible-test-splitter SUCCESS in 5m 22s
✔️ integration-amazon.aws-1 SUCCESS in 9m 06s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 983cbe9 into ansible-collections:main Aug 2, 2023
37 checks passed
@patchback
Copy link

patchback bot commented Aug 2, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/983cbe90f0d5b990ae8110b0717b50c36b4a1d76/pr-1683

Backported as #1686

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 2, 2023
route53: add wait_id return value in case of changes

SUMMARY
This allows to wait for changes later on when wait=false is provided to the module.
Will be needed for a new route53_wait module I'll create a PR for soon in community.aws :)
(I'm not sure whether another 5.x.0 feature release is planned; in case it is not I'll update version_added and the backport-5 label needs to be removed.)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
route53

Reviewed-by: Mark Chappell
(cherry picked from commit 983cbe9)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Aug 2, 2023
[PR #1683/983cbe90 backport][stable-6] route53: add wait_id return value in case of changes

This is a backport of PR #1683 as merged into main (983cbe9).
SUMMARY
This allows to wait for changes later on when wait=false is provided to the module.
Will be needed for a new route53_wait module I'll create a PR for soon in community.aws :)
(I'm not sure whether another 5.x.0 feature release is planned; in case it is not I'll update version_added and the backport-5 label needs to be removed.)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
route53

Reviewed-by: Alina Buzachis
@felixfontein felixfontein deleted the route53-wait_id branch August 2, 2023 21:48
@felixfontein
Copy link
Contributor Author

@tremble @hakbailey @alinabuzachis thanks a lot!

krisek pushed a commit to krisek/amazon.aws that referenced this pull request Aug 31, 2023
…ions#1683)

route53: add wait_id return value in case of changes

SUMMARY
This allows to wait for changes later on when wait=false is provided to the module.
Will be needed for a new route53_wait module I'll create a PR for soon in community.aws :)
(I'm not sure whether another 5.x.0 feature release is planned; in case it is not I'll update version_added and the backport-5 label needs to be removed.)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
route53

Reviewed-by: Mark Chappell
softwarefactory-project-zuul bot pushed a commit to ansible-collections/community.aws that referenced this pull request Sep 5, 2023
Add route53_wait module

SUMMARY
Add a route53_wait module. This allows to wait for updated/added Route53 DNS entries to propagate when the route53 module was called with wait=false.
Depends on ansible-collections/amazon.aws#1683, thus the tests shouldn't really do anything right now.
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
route53

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis
patchback bot pushed a commit to ansible-collections/community.aws that referenced this pull request Sep 5, 2023
Add route53_wait module

SUMMARY
Add a route53_wait module. This allows to wait for updated/added Route53 DNS entries to propagate when the route53 module was called with wait=false.
Depends on ansible-collections/amazon.aws#1683, thus the tests shouldn't really do anything right now.
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
route53

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis
(cherry picked from commit a7cddf0)
softwarefactory-project-zuul bot pushed a commit to ansible-collections/community.aws that referenced this pull request Sep 6, 2023
[PR #1904/a7cddf0e backport][stable-6] Add route53_wait module

This is a backport of PR #1904 as merged into main (a7cddf0).
SUMMARY
Add a route53_wait module. This allows to wait for updated/added Route53 DNS entries to propagate when the route53 module was called with wait=false.
Depends on ansible-collections/amazon.aws#1683, thus the tests shouldn't really do anything right now.
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
route53

Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Add route53_wait module

SUMMARY
Add a route53_wait module. This allows to wait for updated/added Route53 DNS entries to propagate when the route53 module was called with wait=false.
Depends on ansible-collections#1683, thus the tests shouldn't really do anything right now.
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
route53

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Add route53_wait module

SUMMARY
Add a route53_wait module. This allows to wait for updated/added Route53 DNS entries to propagate when the route53 module was called with wait=false.
Depends on ansible-collections#1683, thus the tests shouldn't really do anything right now.
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
route53

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-6 PR should be backported to the stable-6 branch community_review feature This issue/PR relates to a feature request has_issue integration tests/integration mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants