[PR #1893/06b729ce backport][stable-6] ec2_metadata_facts - Skip tests against 2.7 hosts when running Ansible-core >= 2.17 #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
…e-core >= 2.17 (#1893) ec2_metadata_facts - Skip tests against 2.7 hosts when running Ansible-core >= 2.17 SUMMARY ansible-core 2.17 will drop support for Python 2.7. While in general we require Python > 3.7, we've had an exception for ec2_metadata_facts since it doesn't actually need botocore and it's used outside of the AWS ecosystem. Unfortunately it's no longer possible to test against 2.7 targets using the devel branch, so we'll have to skip those tests in CI (can still be run locally if folks are using ansible-core <2.17 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_metadata_facts ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <mgraves@redhat.com> (cherry picked from commit 06b729c)
alinabuzachis
approved these changes
Dec 4, 2023
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 58s |
softwarefactory-project-zuul
bot
merged commit 45d1f22
into
stable-6
58 of 79 checks passed
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-6/06b729ce67cb674a71356f5a01912a9af3149fd3/pr-1893
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1893 as merged into main (06b729c).
SUMMARY
ansible-core 2.17 will drop support for Python 2.7. While in general we require Python > 3.7, we've had an exception for ec2_metadata_facts since it doesn't actually need botocore and it's used outside of the AWS ecosystem.
Unfortunately it's no longer possible to test against 2.7 targets using the devel branch, so we'll have to skip those tests in CI (can still be run locally if folks are using ansible-core <2.17
ISSUE TYPE
COMPONENT NAME
ec2_metadata_facts
ADDITIONAL INFORMATION