Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sanity workflow #1909

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

alinabuzachis
Copy link
Contributor

SUMMARY

Fix sanity workflow

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done this way we continue to apply devel/milestone tests to a bugfix-only branch, which I don't think is the right approach.

The approach from ansible-collections/community.aws#2000 might be better. Lock to the versions from just after 7.0.0's release, and drop devel/milestone.

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Copy link
Contributor

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@gravesm
Copy link
Member

gravesm commented Dec 6, 2023

Done this way we continue to apply devel/milestone tests to a bugfix-only branch, which I don't think is the right approach.

The approach from ansible-collections/community.aws#2000 might be better. Lock to the versions from just after 7.0.0's release, and drop devel/milestone.

I agree this is a more reasonable approach, but I'm not sure if our downstream publishing pipeline will support this. If we are still releasing off the stable-6 branch when ansible 2.17 is released, it will still have to pass sanity tests on 2.17 before being published downstream.

In the interest of getting the 6.x release out, I'm fine with either approach for now, but we may need to revisit this.

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/3f959eab9f8443d995cbb49b9e9b6cd3

ansible-galaxy-importer FAILURE in 10m 55s
✔️ build-ansible-collection SUCCESS in 16m 10s
✔️ ansible-test-splitter SUCCESS in 6m 47s
✔️ integration-amazon.aws-1 SUCCESS in 34m 29s
✔️ integration-amazon.aws-2 SUCCESS in 25m 16s
Skipped 42 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Dec 7, 2023
@tremble
Copy link
Contributor

tremble commented Dec 7, 2023

I agree this is a more reasonable approach, but I'm not sure if our downstream publishing pipeline will support this. If we are still releasing off the stable-6 branch when ansible 2.17 is released, it will still have to pass sanity tests on 2.17 before being published downstream.

We've been releasing on a cadence that has our next major version available with the next major version of Ansible. As such I would expect us to be releasing 7.0.0 and dropping stable-6 at about the same time Ansible collections 10 enters the feature freeze.

@tremble
Copy link
Contributor

tremble commented Dec 7, 2023

recheck

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3138217e776a4d8d9fad2a3a47f09542

✔️ ansible-galaxy-importer SUCCESS in 3m 50s
✔️ build-ansible-collection SUCCESS in 15m 28s
✔️ ansible-test-splitter SUCCESS in 5m 16s
✔️ integration-amazon.aws-1 SUCCESS in 40m 00s
✔️ integration-amazon.aws-2 SUCCESS in 25m 08s
Skipped 42 jobs

Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/f56a019cc91d466a94b16279f7be36d2

ansible-galaxy-importer RETRY_LIMIT in 7m 17s
✔️ build-ansible-collection SUCCESS in 14m 46s
✔️ ansible-test-splitter SUCCESS in 5m 18s
integration-amazon.aws-1 RETRY_LIMIT in 1m 44s
integration-amazon.aws-2 RETRY_LIMIT in 6m 55s
Skipped 42 jobs

@alinabuzachis
Copy link
Contributor Author

regate

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/c6f80de181f14b54bef73224c1cadf4d

✔️ ansible-galaxy-importer SUCCESS in 3m 49s
✔️ build-ansible-collection SUCCESS in 13m 58s
✔️ ansible-test-splitter SUCCESS in 5m 19s
✔️ integration-amazon.aws-1 SUCCESS in 32m 25s
✔️ integration-amazon.aws-2 SUCCESS in 27m 51s
Skipped 42 jobs

Copy link
Contributor

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@tremble tremble merged commit 34b7a30 into ansible-collections:stable-6 Dec 7, 2023
55 of 58 checks passed
@tremble
Copy link
Contributor

tremble commented Dec 7, 2023

Manual merge (touches .github directory)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory) skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants