ec2_instance: add support for modifying instance metadata options #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandar242
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
force-pushed
the
ec2_instance_metadata_options_update
branch
from
2f8446c
to
58c5c67
Compare
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
force-pushed
the
ec2_instance_metadata_options_update
branch
from
58c5c67
to
ce4a479
Compare
mandar242
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
mandar242
force-pushed
the
ec2_instance_metadata_options_update
branch
from
7b8e735
to
4f9c56e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
hakbailey
reviewed
Dec 15, 2023
tests/integration/targets/ec2_instance_metadata_options/tasks/main.yml
Outdated
Show resolved
Hide resolved
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
mandar242
force-pushed
the
ec2_instance_metadata_options_update
branch
from
e8fdc3a
to
3e10c43
Compare
tremble
requested changes
Dec 18, 2023
mandar242
force-pushed
the
ec2_instance_metadata_options_update
branch
from
b751ea5
to
3e10c43
Compare
Reverted. |
mandar242
force-pushed
the
ec2_instance_metadata_options_update
branch
from
3e10c43
to
71a0b12
Compare
abikouo
approved these changes
Dec 18, 2023
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
tremble
approved these changes
Dec 19, 2023
This comment was marked as outdated.
This comment was marked as outdated.
tremble
approved these changes
Dec 19, 2023
hakbailey
reviewed
Dec 19, 2023
hakbailey
reviewed
Dec 19, 2023
tests/integration/targets/ec2_instance_metadata_options/tasks/main.yml
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…nstane not in running
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
softwarefactory-project-zuul
bot
merged commit cef7268
into
ansible-collections:main
37 of 40 checks passed
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #1934 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
) ec2_instance: add support for modifying instance metadata options SUMMARY Fixes #1864 This PR add support for modifying instance metadata options. Uses client. modify_instance_metadata_options() ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <hebailey@redhat.com> Reviewed-by: Mark Chappell Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> (cherry picked from commit cef7268)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
) (#1934) [PR #1918/cef72686 backport][stable-7] ec2_instance: add support for modifying instance metadata options This is a backport of PR #1918 as merged into main (cef7268). SUMMARY Fixes #1864 This PR add support for modifying instance metadata options. Uses client. modify_instance_metadata_options() ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #1864
This PR add support for modifying instance metadata options.
Uses
client. modify_instance_metadata_options()ISSUE TYPE
COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION