Add retries to most ec2_ami AWS calls #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
force-pushed
the
ec2_ami/retries
branch
2 times, most recently
from
2d92368
to
90970a7
Compare
tremble
force-pushed
the
ec2_ami/retries
branch
from
90970a7
to
87cbbfa
Compare
tremble
changed the title
jillr
approved these changes
Nov 16, 2020
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…sible-collections#195) * Correctly handle a situation when a repository has no description If a repository was created without a description, API call response will not include 'repositoryDescription' attribute: ``` $ aws codecommit get-repository --repository-name test { "repositoryMetadata": { "accountId": "123412341234", "repositoryId": "abcd1234-abcd-abcd-1234-abcd1234abc", "repositoryName": "test", "defaultBranch": "master", "lastModifiedDate": 1597770987.868, "creationDate": 1579544888.152, "cloneUrlHttp": "https://git-codecommit.us-east-1.amazonaws.com/v1/repos/test", "cloneUrlSsh": "ssh://git-codecommit.us-east-1.amazonaws.com/v1/repos/test", "Arn": "arn:aws:codecommit:us-east-1:123412341234:test" } } ``` As a result, module execution fails with the following stacktrace: ``` Traceback (most recent call last): File \"/root/.ansible/tmp/ansible-tmp-1597769457.193254-7427-16306174619296/AnsiballZ_aws_codecommit.py\", line 102, in <module> _ansiballz_main() File \"/root/.ansible/tmp/ansible-tmp-1597769457.193254-7427-16306174619296/AnsiballZ_aws_codecommit.py\", line 94, in _ansiballz_main invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS) File \"/root/.ansible/tmp/ansible-tmp-1597769457.193254-7427-16306174619296/AnsiballZ_aws_codecommit.py\", line 40, in invoke_module runpy.run_module(mod_name='ansible_collections.community.aws.plugins.modules.aws_codecommit', init_globals=None, run_name='__main__', alter_sys=True) File \"/root/.pyenv/versions/3.8.1/lib/python3.8/runpy.py\", line 206, in run_module return _run_module_code(code, init_globals, run_name, mod_spec) File \"/root/.pyenv/versions/3.8.1/lib/python3.8/runpy.py\", line 96, in _run_module_code _run_code(code, mod_globals, init_globals, File \"/root/.pyenv/versions/3.8.1/lib/python3.8/runpy.py\", line 86, in _run_code exec(code, run_globals) File \"/tmp/ansible_community.aws.aws_codecommit_payload_0zfnkbv7/ansible_community.aws.aws_codecommit_payload.zip/ansible_collections/community/aws/plugins/modules/aws_codecommit.py\", line 245, in <module> File \"/tmp/ansible_community.aws.aws_codecommit_payload_0zfnkbv7/ansible_community.aws.aws_codecommit_payload.zip/ansible_collections/community/aws/plugins/modules/aws_codecommit.py\", line 240, in main File \"/tmp/ansible_community.aws.aws_codecommit_payload_0zfnkbv7/ansible_community.aws.aws_codecommit_payload.zip/ansible_collections/community/aws/plugins/modules/aws_codecommit.py\", line 165, in process KeyError: 'repositoryDescription' ``` * Add integration tests Additional tests do the following: - Create a new repository with no description - Update a repository with no description - Delete a repository * Add change log fragment Co-authored-by: Ivan Chekaldin <ivan.chekaldin@blackboard.com>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…sible-collections#195) * Correctly handle a situation when a repository has no description If a repository was created without a description, API call response will not include 'repositoryDescription' attribute: ``` $ aws codecommit get-repository --repository-name test { "repositoryMetadata": { "accountId": "123412341234", "repositoryId": "abcd1234-abcd-abcd-1234-abcd1234abc", "repositoryName": "test", "defaultBranch": "master", "lastModifiedDate": 1597770987.868, "creationDate": 1579544888.152, "cloneUrlHttp": "https://git-codecommit.us-east-1.amazonaws.com/v1/repos/test", "cloneUrlSsh": "ssh://git-codecommit.us-east-1.amazonaws.com/v1/repos/test", "Arn": "arn:aws:codecommit:us-east-1:123412341234:test" } } ``` As a result, module execution fails with the following stacktrace: ``` Traceback (most recent call last): File \"/root/.ansible/tmp/ansible-tmp-1597769457.193254-7427-16306174619296/AnsiballZ_aws_codecommit.py\", line 102, in <module> _ansiballz_main() File \"/root/.ansible/tmp/ansible-tmp-1597769457.193254-7427-16306174619296/AnsiballZ_aws_codecommit.py\", line 94, in _ansiballz_main invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS) File \"/root/.ansible/tmp/ansible-tmp-1597769457.193254-7427-16306174619296/AnsiballZ_aws_codecommit.py\", line 40, in invoke_module runpy.run_module(mod_name='ansible_collections.community.aws.plugins.modules.aws_codecommit', init_globals=None, run_name='__main__', alter_sys=True) File \"/root/.pyenv/versions/3.8.1/lib/python3.8/runpy.py\", line 206, in run_module return _run_module_code(code, init_globals, run_name, mod_spec) File \"/root/.pyenv/versions/3.8.1/lib/python3.8/runpy.py\", line 96, in _run_module_code _run_code(code, mod_globals, init_globals, File \"/root/.pyenv/versions/3.8.1/lib/python3.8/runpy.py\", line 86, in _run_code exec(code, run_globals) File \"/tmp/ansible_community.aws.aws_codecommit_payload_0zfnkbv7/ansible_community.aws.aws_codecommit_payload.zip/ansible_collections/community/aws/plugins/modules/aws_codecommit.py\", line 245, in <module> File \"/tmp/ansible_community.aws.aws_codecommit_payload_0zfnkbv7/ansible_community.aws.aws_codecommit_payload.zip/ansible_collections/community/aws/plugins/modules/aws_codecommit.py\", line 240, in main File \"/tmp/ansible_community.aws.aws_codecommit_payload_0zfnkbv7/ansible_community.aws.aws_codecommit_payload.zip/ansible_collections/community/aws/plugins/modules/aws_codecommit.py\", line 165, in process KeyError: 'repositoryDescription' ``` * Add integration tests Additional tests do the following: - Create a new repository with no description - Update a repository with no description - Delete a repository * Add change log fragment Co-authored-by: Ivan Chekaldin <ivan.chekaldin@blackboard.com>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…sible-collections#195) * Correctly handle a situation when a repository has no description If a repository was created without a description, API call response will not include 'repositoryDescription' attribute: ``` $ aws codecommit get-repository --repository-name test { "repositoryMetadata": { "accountId": "123412341234", "repositoryId": "abcd1234-abcd-abcd-1234-abcd1234abc", "repositoryName": "test", "defaultBranch": "master", "lastModifiedDate": 1597770987.868, "creationDate": 1579544888.152, "cloneUrlHttp": "https://git-codecommit.us-east-1.amazonaws.com/v1/repos/test", "cloneUrlSsh": "ssh://git-codecommit.us-east-1.amazonaws.com/v1/repos/test", "Arn": "arn:aws:codecommit:us-east-1:123412341234:test" } } ``` As a result, module execution fails with the following stacktrace: ``` Traceback (most recent call last): File \"/root/.ansible/tmp/ansible-tmp-1597769457.193254-7427-16306174619296/AnsiballZ_aws_codecommit.py\", line 102, in <module> _ansiballz_main() File \"/root/.ansible/tmp/ansible-tmp-1597769457.193254-7427-16306174619296/AnsiballZ_aws_codecommit.py\", line 94, in _ansiballz_main invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS) File \"/root/.ansible/tmp/ansible-tmp-1597769457.193254-7427-16306174619296/AnsiballZ_aws_codecommit.py\", line 40, in invoke_module runpy.run_module(mod_name='ansible_collections.community.aws.plugins.modules.aws_codecommit', init_globals=None, run_name='__main__', alter_sys=True) File \"/root/.pyenv/versions/3.8.1/lib/python3.8/runpy.py\", line 206, in run_module return _run_module_code(code, init_globals, run_name, mod_spec) File \"/root/.pyenv/versions/3.8.1/lib/python3.8/runpy.py\", line 96, in _run_module_code _run_code(code, mod_globals, init_globals, File \"/root/.pyenv/versions/3.8.1/lib/python3.8/runpy.py\", line 86, in _run_code exec(code, run_globals) File \"/tmp/ansible_community.aws.aws_codecommit_payload_0zfnkbv7/ansible_community.aws.aws_codecommit_payload.zip/ansible_collections/community/aws/plugins/modules/aws_codecommit.py\", line 245, in <module> File \"/tmp/ansible_community.aws.aws_codecommit_payload_0zfnkbv7/ansible_community.aws.aws_codecommit_payload.zip/ansible_collections/community/aws/plugins/modules/aws_codecommit.py\", line 240, in main File \"/tmp/ansible_community.aws.aws_codecommit_payload_0zfnkbv7/ansible_community.aws.aws_codecommit_payload.zip/ansible_collections/community/aws/plugins/modules/aws_codecommit.py\", line 165, in process KeyError: 'repositoryDescription' ``` * Add integration tests Additional tests do the following: - Create a new repository with no description - Update a repository with no description - Delete a repository * Add change log fragment Co-authored-by: Ivan Chekaldin <ivan.chekaldin@blackboard.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Stabilisation work on ec2_ami and ec2_ami_info
ISSUE TYPE
COMPONENT NAME
ec2_ami
ec2_ami_info
ADDITIONAL INFORMATION
Still to look into