Deprecate template parameter for cloudformation #2048
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 31s |
tremble
added
backport-7
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 5m 56s |
softwarefactory-project-zuul
bot
merged commit 5281e89
into
ansible-collections:main
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #2051 🤖 @patchback |
Deprecate template parameter for cloudformation
SUMMARY
The cloudformation module currently directly uses open() to access files passed using the template parameter. This can be better handled by using template_body and getting folks to use {{ lookup() }}.
The current open based implementation doesn't look in the places that folks might expect to find their files, and doesn't handle templating. In the event folks aren't delegating everything to localhost, this can also result in files simply not being available.
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
cloudformation
ADDITIONAL INFORMATION
Reviewed-by: Alina Buzachis
(cherry picked from commit 5281e89)
[PR #2048/5281e89f backport][stable-7] Deprecate template parameter for cloudformation This is a backport of PR #2048 as merged into main (5281e89). SUMMARY The cloudformation module currently directly uses open() to access files passed using the template parameter. This can be better handled by using template_body and getting folks to use {{ lookup() }}. The current open based implementation doesn't look in the places that folks might expect to find their files, and doesn't handle templating. In the event folks aren't delegating everything to localhost, this can also result in files simply not being available. ISSUE TYPE Feature Pull Request COMPONENT NAME cloudformation ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
SUMMARY
The
cloudformationmodule currently directly usesopen()to access files passed using thetemplateparameter. This can be better handled by usingtemplate_bodyand getting folks to use{{ lookup() }}.The current open based implementation doesn't look in the places that folks might expect to find their files, and doesn't handle templating. In the event folks aren't delegating everything to localhost, this can also result in files simply not being available.
ISSUE TYPE
COMPONENT NAME
cloudformation
ADDITIONAL INFORMATION