Consistently use Retry decorator on ec2_group(_info) #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… retry on missing groups
tremble
force-pushed
the
stability/ec2_group
branch
from
7ebf698
to
5912542
Compare
jillr
approved these changes
Dec 1, 2020
There was a problem hiding this comment.
For posterity, I've specifically looked at https://github.com/ansible-collections/amazon.aws/pull/207/files#diff-2662e61b8cd36633771fa77f2711f866ad852d91d891940c0cfc3c9475f8548dR1036 in light of some of the (recurrent) issues with ec2_group's handling of comparisons and change logic and I think this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Attempt to stabilise the ec2_group integration tests
ISSUE TYPE
COMPONENT NAME
ec2_group
ec2_group_info
ADDITIONAL INFORMATION
Stabilise the last of the amazon.aws tests!