Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #2185/3c6ba70e backport][stable-7] Add 'alternative' for EC2_REGION deprecation for non-module plugins #2186

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jul 9, 2024

This is a backport of PR #2185 as merged into main (3c6ba70).

SUMMARY

Adds "alternative" key to documentation for deprecated EC2_REGION env variable.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

plugins/doc_fragments/region.py

ADDITIONAL INFORMATION

Fixes sanity issue:

 ERROR: Found 5 validate-modules issue(s) which need to be resolved:
ERROR: plugins/inventory/aws_ec2.py:0:0: invalid-documentation: DOCUMENTATION.options.region.env.1.deprecated.Any('alternatives', 'alternative', msg=None): required key not provided @ data['options']['region']['env'][1]['deprecated'][Any('alternatives', 'alternative', msg=None)]. Got None
ERROR: plugins/inventory/aws_rds.py:0:0: invalid-documentation: DOCUMENTATION.options.region.env.1.deprecated.Any('alternatives', 'alternative', msg=None): required key not provided @ data['options']['region']['env'][1]['deprecated'][Any('alternatives', 'alternative', msg=None)]. Got None
ERROR: plugins/lookup/aws_account_attribute.py:0:0: invalid-documentation: DOCUMENTATION.options.region.env.1.deprecated.Any('alternatives', 'alternative', msg=None): required key not provided @ data['options']['region']['env'][1]['deprecated'][Any('alternatives', 'alternative', msg=None)]. Got None
ERROR: plugins/lookup/secretsmanager_secret.py:0:0: invalid-documentation: DOCUMENTATION.options.region.env.1.deprecated.Any('alternatives', 'alternative', msg=None): required key not provided @ data['options']['region']['env'][1]['deprecated'][Any('alternatives', 'alternative', msg=None)]. Got None
ERROR: plugins/lookup/ssm_parameter.py:0:0: invalid-documentation: DOCUMENTATION.options.region.env.1.deprecated.Any('alternatives', 'alternative', msg=None): required key not provided @ data['options']['region']['env'][1]['deprecated'][Any('alternatives', 'alternative', msg=None)]. Got None

…2185)

SUMMARY
Adds "alternative" key to documentation for deprecated EC2_REGION env variable.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/doc_fragments/region.py
ADDITIONAL INFORMATION
Fixes sanity issue:
 ERROR: Found 5 validate-modules issue(s) which need to be resolved:
ERROR: plugins/inventory/aws_ec2.py:0:0: invalid-documentation: DOCUMENTATION.options.region.env.1.deprecated.Any('alternatives', 'alternative', msg=None): required key not provided @ data['options']['region']['env'][1]['deprecated'][Any('alternatives', 'alternative', msg=None)]. Got None
ERROR: plugins/inventory/aws_rds.py:0:0: invalid-documentation: DOCUMENTATION.options.region.env.1.deprecated.Any('alternatives', 'alternative', msg=None): required key not provided @ data['options']['region']['env'][1]['deprecated'][Any('alternatives', 'alternative', msg=None)]. Got None
ERROR: plugins/lookup/aws_account_attribute.py:0:0: invalid-documentation: DOCUMENTATION.options.region.env.1.deprecated.Any('alternatives', 'alternative', msg=None): required key not provided @ data['options']['region']['env'][1]['deprecated'][Any('alternatives', 'alternative', msg=None)]. Got None
ERROR: plugins/lookup/secretsmanager_secret.py:0:0: invalid-documentation: DOCUMENTATION.options.region.env.1.deprecated.Any('alternatives', 'alternative', msg=None): required key not provided @ data['options']['region']['env'][1]['deprecated'][Any('alternatives', 'alternative', msg=None)]. Got None
ERROR: plugins/lookup/ssm_parameter.py:0:0: invalid-documentation: DOCUMENTATION.options.region.env.1.deprecated.Any('alternatives', 'alternative', msg=None): required key not provided @ data['options']['region']['env'][1]['deprecated'][Any('alternatives', 'alternative', msg=None)]. Got None

Reviewed-by: Alina Buzachis
(cherry picked from commit 3c6ba70)
Copy link

github-actions bot commented Jul 9, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e40f3489e7a844b0b52a9c861c650213

✔️ ansible-galaxy-importer SUCCESS in 3m 54s
✔️ build-ansible-collection SUCCESS in 13m 19s
✔️ ansible-test-splitter SUCCESS in 5m 15s
Skipped 44 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 15, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/6dc2e19c496d4e789a40467f3be849d0

✔️ ansible-galaxy-importer SUCCESS in 8m 10s
✔️ build-ansible-collection SUCCESS in 12m 33s
✔️ ansible-test-splitter SUCCESS in 5m 22s
Skipped 44 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a71281a into stable-7 Jul 15, 2024
37 checks passed
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-7/3c6ba70e6e3a7477a0fd2b96b754958e848cb76c/pr-2185 branch July 15, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant