inventory/aws2_ec2: avoid extra Display import #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
The superclass does appear to include display in self, which is imported identically to the way it had been in this module.
https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/inventory/__init__.py#L39
/ https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/inventory/__init__.py#L161
Change looks sane and tests pass
|
@jillr / @felixfontein Do you feel this change warrants a changelog entry? |
|
@tremble good question. I tend to say "all code changes need one", to stop having to think about such cases ;-) |
The `BaseInventoryPlugin` class already expose an instance of `ansible.utils.display.Display`. We don't to recreate it.
goneri
force-pushed
the
inventory-aws2_ec2-avoid-extra-Display-import_2514
branch
from
559caf2
to
d53dd6a
Compare
tremble
requested changes
Jan 7, 2021
Co-authored-by: Mark Chappell <mchappel@redhat.com>
Akasurde
reviewed
Jan 8, 2021
felixfontein
reviewed
Jan 8, 2021
Co-authored-by: Felix Fontein <felix@fontein.de>
tremble
approved these changes
Jan 8, 2021
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…_protocol_versions (ansible-collections#226) Co-authored-by: Andreas Jonsson <andreas.jonsson@ensighten.com>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…_protocol_versions (ansible-collections#226) Co-authored-by: Andreas Jonsson <andreas.jonsson@ensighten.com>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…_protocol_versions (ansible-collections#226) Co-authored-by: Andreas Jonsson <andreas.jonsson@ensighten.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BaseInventoryPluginclass already expose an instance ofansible.utils.display.Display. We don't to recreate it.