Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_account_attribute - AWSRetry (+integration tests) #295

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Mar 9, 2021

SUMMARY

Add AWSRetry to aws_account_attributes

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aws_account_attribute

ADDITIONAL INFORMATION

@tremble tremble changed the title aws_account_attributes - AWSRetry (+integration tests) aws_account_attribute - AWSRetry (+integration tests) Mar 9, 2021
@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration lookup lookup plugin needs_triage plugins plugin (any type) tests tests labels Mar 9, 2021
@tremble tremble requested a review from jillr March 9, 2021 19:48
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on an EC2-Classic account; LGTM

@jillr jillr merged commit 03aefc7 into ansible-collections:main Mar 9, 2021
@tremble tremble deleted the awsretry/aws_account_attribute branch May 28, 2021 07:08
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
* Flag aws_ssm as unstable rather than disabled

* Try tweaking the policy

* no security_token

* Use module_defaults rather than fact hack

* Fix session token env var

* Move bucket creation to avoid aws-terminator whacking it.

* Change the order of Instance creation, Windows takes longer to start.

* Add reset call to aws_ssm

* Add a wait_for_connection call at the start of the connection tests.
Reduce the delay waiting on the EC2 instances

* Explicitly call community.aws.aws_ssm - looks like 2.9 isn't redirecting properly

* Try running SSM connection tests in parallel.

* Delay a little more

* Turn file names into a variable, and make sure they're unique to the host.

* Try bumping up the instance size

* More delays...

* Remove unused imports

* Move botocore import into HAS_BOTO3 try block

* Make sure that path_unescaped initial string is unicode because out_path can be

* Don't wait for the Windows VM before starting the Linux one

* Add a note why the test is 'unstable'

* Use EBS optimized volumes to improve Windows boot speed.

* Try disabling the Windows connection test - Windows is very slow to start

* instances sometimes isn't there if the host took to long to start, use instance_ids

* changelog

* Remove duplicate wait

* Move to more modern instance type

* Don't try installing boto, it's already available in the images

* remove debugging

* Remove old (unused) inventory templates

* Add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration lookup lookup plugin needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants