scrub_none_parameters - set default for descend_into_lists to True (breaking change) #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
|
@tremble can you add a changelog for this please? |
ansibullbot
added
needs_revision
ansibullbot
added
community_review
and removed
needs_revision
|
@jillr Added. (to those looking at the history - Jill asked before I pushed the commit, but the commit was written before the request) |
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Awsretry/cloudfront distribution SUMMARY Adding AWSRetry.exponential_backoff when updating a cloudfront distribution. Fixes ansible-collections#296 ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: matej <strahek@gmail.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Francesc Navarro <fnavarro@debelop.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Awsretry/cloudfront distribution SUMMARY Adding AWSRetry.exponential_backoff when updating a cloudfront distribution. Fixes ansible-collections#296 ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: matej <strahek@gmail.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Francesc Navarro <fnavarro@debelop.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Awsretry/cloudfront distribution SUMMARY Adding AWSRetry.exponential_backoff when updating a cloudfront distribution. Fixes ansible-collections#296 ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudfront_distribution Reviewed-by: matej <strahek@gmail.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Francesc Navarro <fnavarro@debelop.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Follow up to #262 set the default for descend_into_lists to True since this is what folks will want most of the time.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/core.py
ADDITIONAL INFORMATION
Needs to wait for the 2.0 freeze.