aws2_ec2 inventory: populate ec2_tag_* hostvars #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibullbot
added
inventory
goneri
force-pushed
the
aws2_ec2-inventory-populate-ec2_tag_-hostvars_30441
branch
from
712fd84
to
a13e788
Compare
I'm on it! |
goneri
force-pushed
the
aws2_ec2-inventory-populate-ec2_tag_-hostvars_30441
branch
from
a13e788
to
f002d94
Compare
goneri
force-pushed
the
aws2_ec2-inventory-populate-ec2_tag_-hostvars_30441
branch
from
f002d94
to
758d4b2
Compare
This patch exposes a new `use_contrib_script_compatible_ec2_tag_keys` that can be used to reproduce a behior of the old `ec2.py` inventory script from contrib. Closes: ansible-collections#183
goneri
force-pushed
the
aws2_ec2-inventory-populate-ec2_tag_-hostvars_30441
branch
from
758d4b2
to
e827363
Compare
jillr
approved these changes
Apr 20, 2021
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 7, 2022
…_contrib_script_compatible_ec2_tag_keys (#858) Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys SUMMARY Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys include_filters and exclude_filters have been added #328 and released with amazon.aws 1.5.0 use_contrib_script_compatible_ec2_tag_keys has been added #331 and released with amazon.aws 1.5.0 Let's update the aws_ec2 inventory plugin documentation with this information. This should be a step towards closing this one #676 and #675 aws_ec2 documentation will be enriched with exhaustive examples in an upcoming PR. ISSUE TYPE Docs Pull Request COMPONENT NAME aws_ec2 ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
patchback bot
pushed a commit
that referenced
this pull request
Jun 7, 2022
…_contrib_script_compatible_ec2_tag_keys (#858) Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys SUMMARY Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys include_filters and exclude_filters have been added #328 and released with amazon.aws 1.5.0 use_contrib_script_compatible_ec2_tag_keys has been added #331 and released with amazon.aws 1.5.0 Let's update the aws_ec2 inventory plugin documentation with this information. This should be a step towards closing this one #676 and #675 aws_ec2 documentation will be enriched with exhaustive examples in an upcoming PR. ISSUE TYPE Docs Pull Request COMPONENT NAME aws_ec2 ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None> (cherry picked from commit 5f05853)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jun 7, 2022
…_contrib_script_compatible_ec2_tag_keys (#858) (#868) [PR #858/5f058532 backport][stable-3] Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys This is a backport of PR #858 as merged into main (5f05853). SUMMARY Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys include_filters and exclude_filters have been added #328 and released with amazon.aws 1.5.0 use_contrib_script_compatible_ec2_tag_keys has been added #331 and released with amazon.aws 1.5.0 Let's update the aws_ec2 inventory plugin documentation with this information. This should be a step towards closing this one #676 and #675 aws_ec2 documentation will be enriched with exhaustive examples in an upcoming PR. ISSUE TYPE Docs Pull Request COMPONENT NAME aws_ec2 ADDITIONAL INFORMATION
jatorcasso
pushed a commit
to jatorcasso/amazon.aws
that referenced
this pull request
Jun 27, 2022
…_contrib_script_compatible_ec2_tag_keys (ansible-collections#858) Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys SUMMARY Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys include_filters and exclude_filters have been added ansible-collections#328 and released with amazon.aws 1.5.0 use_contrib_script_compatible_ec2_tag_keys has been added ansible-collections#331 and released with amazon.aws 1.5.0 Let's update the aws_ec2 inventory plugin documentation with this information. This should be a step towards closing this one ansible-collections#676 and ansible-collections#675 aws_ec2 documentation will be enriched with exhaustive examples in an upcoming PR. ISSUE TYPE Docs Pull Request COMPONENT NAME aws_ec2 ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 16, 2022
ec2_eip tagging support SUMMARY Add support for tagging EIPs on creation. Todo: EIP Tagging Tests Retry decorator Note: While it's now possible to pass tagging information into the association call this was only added Dec 2020 so won't work for most folks. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eip ec2_eip_info ADDITIONAL INFORMATION fixes: ansible-collections#331 Reviewed-by: Rick Mendes <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@02836f3
goneri
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 21, 2022
ec2_eip tagging support SUMMARY Add support for tagging EIPs on creation. Todo: EIP Tagging Tests Retry decorator Note: While it's now possible to pass tagging information into the association call this was only added Dec 2020 so won't work for most folks. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eip ec2_eip_info ADDITIONAL INFORMATION fixes: ansible-collections#331 Reviewed-by: Rick Mendes <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@02836f3
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
ec2_eip tagging support SUMMARY Add support for tagging EIPs on creation. Todo: EIP Tagging Tests Retry decorator Note: While it's now possible to pass tagging information into the association call this was only added Dec 2020 so won't work for most folks. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eip ec2_eip_info ADDITIONAL INFORMATION fixes: ansible-collections#331 Reviewed-by: Rick Mendes <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
ec2_eip tagging support SUMMARY Add support for tagging EIPs on creation. Todo: EIP Tagging Tests Retry decorator Note: While it's now possible to pass tagging information into the association call this was only added Dec 2020 so won't work for most folks. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eip ec2_eip_info ADDITIONAL INFORMATION fixes: ansible-collections#331 Reviewed-by: Rick Mendes <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
ec2_eip tagging support SUMMARY Add support for tagging EIPs on creation. Todo: EIP Tagging Tests Retry decorator Note: While it's now possible to pass tagging information into the association call this was only added Dec 2020 so won't work for most folks. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eip ec2_eip_info ADDITIONAL INFORMATION fixes: ansible-collections#331 Reviewed-by: Rick Mendes <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch exposes a new
use_contrib_script_compatible_ec2_tag_keysthat can be used to reproduce a behior of the old
ec2.pyinventoryscript from contrib.
Closes: #183