Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] ec2_vol: Fix iops setting and enforce iops/throughput parameters usage #334

Closed
wants to merge 3 commits into from
Closed

[WIP] ec2_vol: Fix iops setting and enforce iops/throughput parameters usage #334

wants to merge 3 commits into from

Conversation

alinabuzachis
Copy link
Contributor

SUMMARY

ec2_vol: Fix iops setting and enforce iops/throughput parameters usage
Fixes: #330

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_vol

ADDITIONAL INFORMATION

@ansibullbot
Copy link

cc @jillr @lwade @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress bug This issue/PR relates to a bug integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Apr 21, 2021
@alinabuzachis
ec2_vol: Fix iops setting and enforce iops/throughput parameters usage
5c86f6a 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@alinabuzachis
* Attempt to use FQDN
b593e0a 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@alinabuzachis alinabuzachis mentioned this pull request Apr 23, 2021
Merged
2 tasks
@alinabuzachis
* Add changelog
95d1f9c 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@alinabuzachis
Copy link
Contributor Author

recheck

@markuman
Copy link
Member

ping me for code-review when WIP is done.

@markuman markuman mentioned this pull request May 19, 2021
Merged
@markuman
Copy link
Member

/recheck

@markuman markuman mentioned this pull request May 20, 2021
Merged
@jillr
Copy link
Collaborator

jillr commented May 24, 2021

Thanks for picking this up @markuman
@alinabuzachis, do we need to keep this WIP open?

@alinabuzachis
Copy link
Contributor Author

@jillr Thank you. I close it since @markuman opened this PR #371.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug integration tests/integration module module plugins plugin (any type) tests tests WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ec2_vol sets all volumes with an iops field to be io1
4 participants
@alinabuzachis @ansibullbot @markuman @jillr