Add fix to change the no_device parameter value to string #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
srirachanaachyuthuni
changed the title
jillr
reviewed
Jun 14, 2021
There was a problem hiding this comment.
Tiny nit, otherwise this is looking pretty good - thanks @srirachanaachyuthuni!
|
@abikouo Could you give this PR a review when you have a chance please? |
abikouo
requested changes
Jun 14, 2021
abikouo
reviewed
Jun 14, 2021
abikouo
reviewed
Jun 15, 2021
srirachanaachyuthuni
changed the title
jillr
approved these changes
Jun 15, 2021
2d6
pushed a commit
to 2d6/amazon.aws
that referenced
this pull request
Jun 19, 2021
…llections#386) Add fix to change the no_device parameter value to string Reviewed-by: https://github.com/apps/ansible-zuul
goneri
pushed a commit
to goneri/amazon.aws
that referenced
this pull request
Jun 25, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@f7a818b
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 19, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 19, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 19, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 19, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 19, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 19, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
jillr
pushed a commit
to jillr/amazon.aws
that referenced
this pull request
Jul 27, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
jillr
pushed a commit
to jillr/amazon.aws
that referenced
this pull request
Aug 20, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
jillr
pushed a commit
to jillr/amazon.aws
that referenced
this pull request
Aug 26, 2021
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cff6d00
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…nsible-collections#386) * Internet gateway: add missing integration tests and code check * Add CamelCase tags integration test * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings * Add additional integration tests for ec2_vpc_igw_info module Signed-off-by: Alina Buzachis <abuzachis@redhat.com> * Internet Gateway - integration tests * Fix Internet Gatways search by tags * * Apply reviewer suggestions * Better error handling for the waiter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Changes the value of no_device parameter from Bool to String for Boto3
Fixes: #120
ISSUE TYPE
COMPONENT NAME
ec2_ami
ADDITIONAL INFORMATION