EC2_instance: add support for controlling metadata options #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mandar242 this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
feature
mandar242
force-pushed
the
ec2_metadata_opt_support
branch
from
f608eaa
to
d2ae4db
Compare
jillr
removed
merge_commit
ansibullbot
added
community_review
plugins
jillr
reviewed
Jul 26, 2021
|
recheck |
Akasurde
reviewed
Jul 27, 2021
changelogs/fragments/414-ec2_instance-support-controlling-metadata-options.yml
Outdated
Show resolved
Hide resolved
Akasurde
reviewed
Jul 27, 2021
|
recheck |
tremble
requested changes
Aug 13, 2021
There was a problem hiding this comment.
Thanks for your contribution.
With tests it's good to do a four-step test for each 'change'
- Try change in check-mode (assert changed)
- Try change (assert changed and state)
- Repeat change in check-mode (assert not changed)
- Repeat change (assert state and not changed)
tests/integration/targets/ec2_instance/roles/ec2_instance/tasks/metadata_options.yml
Show resolved
Hide resolved
tremble
approved these changes
Aug 17, 2021
tremble
reviewed
Aug 17, 2021
tremble
reviewed
Aug 17, 2021
jillr
approved these changes
Aug 19, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
rds_instance: map Tags parameters from dict to list on restore_db_instance_from_db_snapshot method Reviewed-by: https://github.com/apps/ansible-zuul
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
rds_instance: map Tags parameters from dict to list on restore_db_instance_from_db_snapshot method Reviewed-by: https://github.com/apps/ansible-zuul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding support for controlling the metadata options, 'Metadata Accessible' and 'Metadata Version' in amazon.aws.ec2_instance.
Fixes #399
ISSUE TYPE
COMPONENT NAME
amazon.aws.ec2_instance