Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ec2_key, ec2_snapshot and ec2_group tests #429

Merged
merged 4 commits into from
Aug 5, 2021
Merged

Disable ec2_key, ec2_snapshot and ec2_group tests #429

merged 4 commits into from
Aug 5, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Aug 2, 2021 •
edited
Loading

SUMMARY

Work around #428 and #440 #441

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_key
ec2_snapshot
ec2_group

ADDITIONAL INFORMATION

@tremble tremble requested a review from jillr August 2, 2021 16:24
@ansibullbot
Copy link

cc @jillr @prasadkatti @s-hertel @wimnat @zbal
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration needs_triage plugins plugin (any type) tests tests labels Aug 2, 2021
@tremble
Copy link
Contributor Author

tremble commented Aug 2, 2021

recheck

2 similar comments
@tremble
Copy link
Contributor Author

tremble commented Aug 2, 2021

recheck

@jillr
Copy link
Collaborator

jillr commented Aug 3, 2021

recheck

@jillr jillr mentioned this pull request Aug 3, 2021
Merged
@tremble
Copy link
Contributor Author

tremble commented Aug 3, 2021

recheck

@tremble tremble added the gate label Aug 3, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tremble
Copy link
Contributor Author

tremble commented Aug 3, 2021

recheck

pabelanger
pabelanger reviewed Aug 3, 2021
View reviewed changes
tests/integration/targets/ec2_key/aliases
Comment on lines +1 to +3
# reason: missing-dependency
# We need either the openssl binary, pycrpto, or a compiler on the Py36 and Py38
# Zuul nodes
Copy link
Contributor

@pabelanger pabelanger Aug 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can install this in CI by creating a top-level bindep.txt file with the following:

openssl [test platform:rpm]

for example. https://docs.opendev.org/opendev/bindep/latest/ gives a few more examples.

Copy link
Contributor Author

@tremble tremble Aug 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried adding that file and it still fails:
https://dashboard.zuul.ansible.com/t/ansible/stream/08ad48a55d024770bc7e4766fb3caa82?logfile=console.log

@tremble tremble removed the gate label Aug 3, 2021
@pabelanger
Copy link
Contributor

I can see the issue, give me a little bit (today) to add depends-on here for jobs to fix.

@pabelanger
Copy link
Contributor

recheck

4 similar comments
@pabelanger
Copy link
Contributor

recheck

@tremble
Copy link
Contributor Author

tremble commented Aug 3, 2021

recheck

@tremble
Copy link
Contributor Author

tremble commented Aug 4, 2021

recheck

@tremble
Copy link
Contributor Author

tremble commented Aug 4, 2021

recheck

@ansibullbot ansibullbot added the small_patch Hopefully easy to review label Aug 5, 2021
@ansibullbot
Copy link

cc @willthames
click here for bot help

@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Aug 5, 2021
@tremble tremble added the gate label Aug 5, 2021
@tremble tremble changed the title Disable ec2_key and ec2_group tests Disable ec2_key, ec2_snapshot and ec2_group tests Aug 5, 2021
@ansible-zuul ansible-zuul bot merged commit 4f9a590 into ansible-collections:main Aug 5, 2021
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 6, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (ansible-co…
ee4e739 
…llections#429)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
ansible-zuul bot pushed a commit that referenced this pull request Aug 9, 2021
@mandar242
ec2_group: update documentation for specifying port ranges (#436)
c060264 
ec2_group: update documentation for specifying port ranges

Depends-on: #429
SUMMARY

Added missing part of documentation for specifying port ranges as -1 value in parameter from_port and to_port is only supported for proto:icmp.
Fixes #397

ISSUE TYPE


Docs Pull Request

COMPONENT NAME

ec2_group

Reviewed-by: Jill R <None>
Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 12, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (ansible-co…
baea775 
…llections#429)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 13, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (ansible-co…
b2c9381 
…llections#429)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 13, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (ansible-co…
455931c 
…llections#429)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 13, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (ansible-co…
6508218 
…llections#429)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 13, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (ansible-co…
deae84d 
…llections#429)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 13, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (ansible-co…
c3095fb 
…llections#429)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 13, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (ansible-co…
98d5dd4 
…llections#429)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (ansible-co…
43ee9dc 
…llections#429)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (ansible-co…
799faa5 
…llections#429)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (ansible-co…
4570cbb 
…llections#429)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (ansible-co…
c9bb288 
…llections#429)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (ansible-co…
cde0cf0 
…llections#429)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (ansible-co…
4a53307 
…llections#429)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
alinabuzachis pushed a commit that referenced this pull request Aug 25, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (#429)
bc32adc 
This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
alinabuzachis pushed a commit that referenced this pull request Aug 25, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (#429)
3634dd9 
This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
alinabuzachis pushed a commit that referenced this pull request Aug 26, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (#429)
a4e8544 
This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
alinabuzachis pushed a commit that referenced this pull request Aug 26, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (#429)
1c896d3 
This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 26, 2021
@tremble @alinabuzachis
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (ansible-co…
1df136e 
…llections#429)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
jillr pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 27, 2021
@tremble @jillr
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (ansible-co…
e46abac 
…llections#429)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cd1430d
@tremble tremble deleted the tests/disable-ec2_key branch November 26, 2021 12:42
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@tremble
Mark the ec2_vpc_nat_gateway integration tests 'unstable' (ansible-co…
cd1430d 
…llections#429)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabelanger pabelanger pabelanger left review comments

@jillr jillr jillr approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul approved these changes

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tremble @ansibullbot @jillr @pabelanger