Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_ami - ensure tags are propagated to the snapshot(s) #437

Merged

Conversation

alinabuzachis
Copy link
Contributor

@alinabuzachis alinabuzachis commented Aug 4, 2021

SUMMARY

ec2_ami - ensure tags are propagated to the snapshot(s) when creating an AMI.

Fixes #368

Using --tag-specifications would introduce additional complexity for handling tags within the ec2_ami module. A simple approach would be to ensure tags propagation during AMI creation to the snapshot(s) and then edit snapshot(s) tags using the ec2_tag module.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_ami

… an AMI

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Aug 4, 2021
@alinabuzachis
Copy link
Contributor Author

recheck

1 similar comment
@alinabuzachis
Copy link
Contributor Author

recheck

@jillr jillr added the gate label Aug 19, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 54e1f95 into ansible-collections:main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag AMI Snapshots
4 participants