Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use a generator rather than list comprehension when using any() #465

Merged
merged 1 commit into from
Aug 13, 2021
Merged

use a generator rather than list comprehension when using any() #465

merged 1 commit into from
Aug 13, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Aug 12, 2021

SUMMARY

pylint cleanup

See also https://www.python.org/dev/peps/pep-0289/#rationale

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/inventory/aws_ec2.py
plugins/modules/ec2_group.py

ADDITIONAL INFORMATION

@ansibullbot
Copy link

cc @adq @jillr @s-hertel @wimnat
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review inventory inventory plugin module module needs_triage plugins plugin (any type) tests tests labels Aug 12, 2021
@tremble tremble added the gate label Aug 13, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 1345e92 into ansible-collections:main Aug 13, 2021
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 13, 2021
@tremble @alinabuzachis
Fix version_added and changelog from ansible-collections#460 (ansible…
979c29e 
…-collections#465)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4f8c366
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 13, 2021
@tremble @alinabuzachis
Fix version_added and changelog from ansible-collections#460 (ansible…
da50565 
…-collections#465)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4f8c366
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 13, 2021
@tremble @alinabuzachis
Fix version_added and changelog from ansible-collections#460 (ansible…
6f968ee 
…-collections#465)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4f8c366
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
@tremble @alinabuzachis
Fix version_added and changelog from ansible-collections#460 (ansible…
05ca16f 
…-collections#465)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4f8c366
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
@tremble @alinabuzachis
Fix version_added and changelog from ansible-collections#460 (ansible…
632fe81 
…-collections#465)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4f8c366
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
@tremble @alinabuzachis
Fix version_added and changelog from ansible-collections#460 (ansible…
1735008 
…-collections#465)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4f8c366
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
@tremble @alinabuzachis
Fix version_added and changelog from ansible-collections#460 (ansible…
9228809 
…-collections#465)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4f8c366
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
@tremble @alinabuzachis
Fix version_added and changelog from ansible-collections#460 (ansible…
eae07af 
…-collections#465)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4f8c366
alinabuzachis pushed a commit that referenced this pull request Aug 25, 2021
@tremble @alinabuzachis
Fix version_added and changelog from #460 (#465)
541217c 
This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4f8c366
alinabuzachis pushed a commit that referenced this pull request Aug 25, 2021
@tremble @alinabuzachis
Fix version_added and changelog from #460 (#465)
2eb0db1 
This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4f8c366
alinabuzachis pushed a commit that referenced this pull request Aug 25, 2021
@tremble @alinabuzachis
Fix version_added and changelog from #460 (#465)
f626e39 
This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4f8c366
alinabuzachis pushed a commit that referenced this pull request Aug 26, 2021
@tremble @alinabuzachis
Fix version_added and changelog from #460 (#465)
3c9d2d2 
This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4f8c366
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 26, 2021
@tremble @alinabuzachis
Fix version_added and changelog from ansible-collections#460 (ansible…
d90540d 
…-collections#465)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4f8c366
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 26, 2021
@tremble @alinabuzachis
Fix version_added and changelog from ansible-collections#460 (ansible…
d6dcb48 
…-collections#465)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4f8c366
@tremble tremble deleted the pylint/generator branch November 26, 2021 12:42
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@tremble
Fix version_added and changelog from ansible-collections#460 (ansible…
3ae75ae 
…-collections#465)
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@tremble @abikouo
Fix version_added and changelog from ansible-collections#460 (ansible…
80f6636 
…-collections#465)
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@tremble
Fix version_added and changelog from ansible-collections#460 (ansible…
4f8c366 
…-collections#465)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul approved these changes

@alinabuzachis alinabuzachis Awaiting requested review from alinabuzachis

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review inventory inventory plugin module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tremble @ansibullbot @felixfontein