Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_ami: Add check_mode support to ec2_ami #516

Merged
merged 4 commits into from
Oct 1, 2021
Merged

ec2_ami: Add check_mode support to ec2_ami #516

merged 4 commits into from
Oct 1, 2021

Conversation

mandar242
Copy link
Contributor

SUMMARY

Add check_mode support to ec2_ami.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_ami

@ansibullbot
Copy link

cc @Constantin07 @gunzy83 @jillr @s-hertel @scicoin-project @tremble @wilvk @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Sep 30, 2021
tremble
tremble requested changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mandar242,

Generally looks good. Please add a changelog fragment.

alinabuzachis
alinabuzachis approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mandar242 Thank you. LGTM!

@tremble tremble added the gate label Oct 1, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 836dbde into ansible-collections:main Oct 1, 2021
@mandar242 mandar242 deleted the ec2_ami_check_mode_support branch October 4, 2021 17:18
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 9, 2022
@tremble @alinabuzachis
rds_instance - fix idempotency when using non-lowercase for preferred…
4624a33 
…_maintenance_window (ansible-collections#516)

* rds_instance - preferred_maintenance_window - force day of week into lowercase
* add integration test
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@8fbfead
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 9, 2022
@tremble @alinabuzachis
rds_instance - fix idempotency when using non-lowercase for preferred…
ad797b6 
…_maintenance_window (ansible-collections#516)

* rds_instance - preferred_maintenance_window - force day of week into lowercase
* add integration test
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@8fbfead
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 9, 2022
@tremble @alinabuzachis
rds_instance - fix idempotency when using non-lowercase for preferred…
013bfce 
…_maintenance_window (ansible-collections#516)

* rds_instance - preferred_maintenance_window - force day of week into lowercase
* add integration test
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@8fbfead
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 9, 2022
@tremble @alinabuzachis
rds_instance - fix idempotency when using non-lowercase for preferred…
9a6684e 
…_maintenance_window (ansible-collections#516)

* rds_instance - preferred_maintenance_window - force day of week into lowercase
* add integration test
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@8fbfead
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 16, 2022
@tremble @alinabuzachis
rds_instance - fix idempotency when using non-lowercase for preferred…
7090c3f 
…_maintenance_window (ansible-collections#516)

* rds_instance - preferred_maintenance_window - force day of week into lowercase
* add integration test
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@8fbfead
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@tremble @goneri
rds_instance - fix idempotency when using non-lowercase for preferred…
36159b8 
…_maintenance_window (ansible-collections#516)

* rds_instance - preferred_maintenance_window - force day of week into lowercase
* add integration test
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@8fbfead
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@tremble @goneri
rds_instance - fix idempotency when using non-lowercase for preferred…
49027d1 
…_maintenance_window (ansible-collections#516)

* rds_instance - preferred_maintenance_window - force day of week into lowercase
* add integration test
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@8fbfead
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@tremble @goneri
rds_instance - fix idempotency when using non-lowercase for preferred…
83a6802 
…_maintenance_window (ansible-collections#516)

* rds_instance - preferred_maintenance_window - force day of week into lowercase
* add integration test
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@8fbfead
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@tremble @goneri
rds_instance - fix idempotency when using non-lowercase for preferred…
7880168 
…_maintenance_window (ansible-collections#516)

* rds_instance - preferred_maintenance_window - force day of week into lowercase
* add integration test
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@8fbfead
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@tremble @goneri
rds_instance - fix idempotency when using non-lowercase for preferred…
32dc2d7 
…_maintenance_window (ansible-collections#516)

* rds_instance - preferred_maintenance_window - force day of week into lowercase
* add integration test
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@8fbfead
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
@tremble @goneri
rds_instance - fix idempotency when using non-lowercase for preferred…
b979f38 
…_maintenance_window (ansible-collections#516)

* rds_instance - preferred_maintenance_window - force day of week into lowercase
* add integration test
* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@8fbfead
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@tremble
rds_instance - fix idempotency when using non-lowercase for preferred…
f14ae2f 
…_maintenance_window (ansible-collections#516)

* rds_instance - preferred_maintenance_window - force day of week into lowercase
* add integration test
* changelog
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@tremble @abikouo
rds_instance - fix idempotency when using non-lowercase for preferred…
0983d08 
…_maintenance_window (ansible-collections#516)

* rds_instance - preferred_maintenance_window - force day of week into lowercase
* add integration test
* changelog
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@tremble
rds_instance - fix idempotency when using non-lowercase for preferred…
8fbfead 
…_maintenance_window (ansible-collections#516)

* rds_instance - preferred_maintenance_window - force day of week into lowercase
* add integration test
* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul approved these changes

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mandar242 @ansibullbot @tremble @alinabuzachis