Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAT Gateway use module_utils helper for tag management #524

Merged
merged 5 commits into from
Oct 5, 2021
Merged

NAT Gateway use module_utils helper for tag management #524

merged 5 commits into from
Oct 5, 2021

Conversation

alinabuzachis
Copy link
Contributor

SUMMARY
  • NAT Gateway use module_utils helper for tag management
  • Cleaning
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ec2_vpc_nat_gateway

@alinabuzachis
Use module_util helper for tag management
3a093a3 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@ansibullbot
Copy link

cc @Etherdaemon @jillr @jonhadfield @linuxdynasty @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review integration tests/integration module module needs_triage new_plugin New plugin plugins plugin (any type) tests tests and removed new_plugin New plugin labels Oct 4, 2021
@alinabuzachis
Add changelog fragment
dfa098b 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@alinabuzachis alinabuzachis force-pushed the ec2_vpc_nat_gateway/mod_util_update branch from 0498474 to dfa098b Compare October 4, 2021 17:23
tremble
tremble requested changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me. One minor niggle but otherwise looks good.

plugins/modules/ec2_vpc_nat_gateway.py Outdated Show resolved Hide resolved
@alinabuzachis alinabuzachis force-pushed the ec2_vpc_nat_gateway/mod_util_update branch from 8f01c13 to b4e33bf Compare October 4, 2021 20:20
@alinabuzachis
Use TagSpecifications
4f05afc 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@alinabuzachis alinabuzachis force-pushed the ec2_vpc_nat_gateway/mod_util_update branch from b4e33bf to 4f05afc Compare October 4, 2021 20:27
tremble
tremble approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting but otherwise good

plugins/modules/ec2_vpc_nat_gateway.py Show resolved Hide resolved
plugins/modules/ec2_vpc_nat_gateway.py Outdated Show resolved Hide resolved
tremble
tremble approved these changes Oct 5, 2021
View reviewed changes
plugins/modules/ec2_vpc_nat_gateway.py Outdated Show resolved Hide resolved
@tremble tremble added the gate label Oct 5, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tremble tremble removed the gate label Oct 5, 2021
@goneri goneri added the gate label Oct 5, 2021
@ansible-zuul ansible-zuul bot merged commit 1d8583f into ansible-collections:main Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul approved these changes

Assignees
No one assigned
Labels
community_review integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alinabuzachis @ansibullbot @tremble @goneri