elb_classic_lb: fix - resolve security_group_ids when providing security_group_names #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
requested changes
Dec 21, 2021
tests/integration/targets/elb_classic_lb/tasks/simple_instances.yml
Outdated
Show resolved
Hide resolved
tremble
approved these changes
Dec 21, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #594 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 21, 2021
…ity_group_names (#592) elb_classic_lb: fix - resolve security_group_ids when providing security_group_names SUMMARY Fix failed to resolve security_group_ids when providing security_group_names. Fix broken tasks in integration tests. Fixes #589. ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_classic_lb Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> (cherry picked from commit a2be6da)
ansible-zuul bot
pushed a commit
that referenced
this pull request
Jan 12, 2022
…ity_group_names (#592) (#594) [PR #592/a2be6da7 backport][stable-2] elb_classic_lb: fix - resolve security_group_ids when providing security_group_names This is a backport of PR #592 as merged into main (a2be6da). SUMMARY Fix failed to resolve security_group_ids when providing security_group_names. Fix broken tasks in integration tests. Fixes #589. ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_classic_lb Reviewed-by: Jill R <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Fix queue attribute comparison SUMMARY Fixes sqs queue attribute comparison so updates are not performed on subsequent runs. Also adds integration tests to verify this behavior. Fixes ansible-collections#578 ISSUE TYPE Bugfix Pull Request COMPONENT NAME sqs_queue ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Fix queue attribute comparison SUMMARY Fixes sqs queue attribute comparison so updates are not performed on subsequent runs. Also adds integration tests to verify this behavior. Fixes ansible-collections#578 ISSUE TYPE Bugfix Pull Request COMPONENT NAME sqs_queue ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix failed to resolve security_group_ids when providing security_group_names.
Fix broken tasks in integration tests.
Fixes #589.
ISSUE TYPE
COMPONENT NAME
elb_classic_lb