Add the ability to disable the validate_bucket_name check #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
jillr
reviewed
Jan 20, 2022
There was a problem hiding this comment.
Thanks for this change @href, could you please add a changelog fragment to tell users about the new option?
The code lgtm
|
I added a fragment, I hope it's adequate. |
|
Build failed.
|
The AWS bucket naming rules are not necessarily enforced on all S3 implementations. Where the rules are not enforced, the validation can now be disabled (it is still on by default). Resolves ansible-collections#593.
|
Build failed.
|
ansibullbot
added
community_review
module
jillr
approved these changes
Feb 8, 2022
|
recheck |
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #662 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Feb 9, 2022
Add the ability to disable the validate_bucket_name check The AWS bucket naming rules are not necessarily enforced on all S3 implementations. Where the rules are not enforced, the validation can now be disabled (it is still on by default). Resolves #593. Reviewed-by: Jill R <None> (cherry picked from commit e802ef6)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 9, 2022
[PR #615/e802ef67 backport][stable-3] Add the ability to disable the validate_bucket_name check This is a backport of PR #615 as merged into main (e802ef6). The AWS bucket naming rules are not necessarily enforced on all S3 implementations. Where the rules are not enforced, the validation can now be disabled (it is still on by default). Resolves #593.
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS bucket naming rules are not necessarily enforced on all S3 implementations. Where the rules are not enforced, the validation can now be disabled (it is still on by default).
Resolves #593.