-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ec2_vpc_igw: fix 'NoneType' object is not subscriptable #691
Merged
softwarefactory-project-zuul
merged 5 commits into
ansible-collections:main
from
jatorcasso:ec2_vpc_igw/fix_NoneType_error
Mar 1, 2022
Merged
ec2_vpc_igw: fix 'NoneType' object is not subscriptable #691
softwarefactory-project-zuul
merged 5 commits into
ansible-collections:main
from
jatorcasso:ec2_vpc_igw/fix_NoneType_error
Mar 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recheck |
Akasurde
reviewed
Feb 28, 2022
Akasurde
reviewed
Feb 28, 2022
jillr
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch on pathAll vs path, this lgmt now - thanks!
recheck |
This change depends on a change that failed to merge. |
recheck |
recheck |
recheck |
Akasurde
approved these changes
Mar 1, 2022
jatorcasso
added a commit
to jatorcasso/amazon.aws
that referenced
this pull request
Mar 1, 2022
…ections#691) ec2_vpc_igw: fix 'NoneType' object is not subscriptable Depends-On: ansible/ansible-zuul-jobs#1368 SUMMARY Add "InternetGatewayAttached" waiter Fixes ansible-collections#647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> Reviewed-by: Abhijeet Kasurde <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 4, 2022
`ec2_vpc_igw`: fix NoneType error SUMMARY use paginator for describe internet gateways and add retry_codes='InvalidInternetGatewayID.NotFound' (thanks @alinabuzachis) Fixes #647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw ADDITIONAL INFORMATION previously added InternetGatewayAttached waiter but problem still persists (#691) Reviewed-by: Abhijeet Kasurde <None> Reviewed-by: Jill R <None>
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Mar 4, 2022
…ections#691) ec2_vpc_igw: fix 'NoneType' object is not subscriptable Depends-On: ansible/ansible-zuul-jobs#1368 SUMMARY Add "InternetGatewayAttached" waiter Fixes ansible-collections#647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> Reviewed-by: Abhijeet Kasurde <None> (cherry picked from commit 8cc9397)
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Mar 4, 2022
…ections#691) ec2_vpc_igw: fix 'NoneType' object is not subscriptable Depends-On: ansible/ansible-zuul-jobs#1368 SUMMARY Add "InternetGatewayAttached" waiter Fixes ansible-collections#647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> Reviewed-by: Abhijeet Kasurde <None> (cherry picked from commit 8cc9397)
This was referenced Mar 4, 2022
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 11, 2022
ec2_vpc_igw: fix 'NoneType' object is not subscriptable (#691) Manual backport to stable-3: ec2_vpc_igw: fix 'NoneType' object is not subscriptable SUMMARY Add "InternetGatewayAttached" waiter Fixes #647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw Reviewed-by: Alina Buzachis Reviewed-by: Joseph Torcasso Reviewed-by: Jill R Reviewed-by: Abhijeet Kasurde (cherry picked from commit 8cc9397) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 11, 2022
ec2_vpc_igw: fix 'NoneType' object is not subscriptable (#691) Manual backport to stable-2: ec2_vpc_igw: fix 'NoneType' object is not subscriptable SUMMARY Add "InternetGatewayAttached" waiter Fixes #647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw Reviewed-by: Alina Buzachis Reviewed-by: Joseph Torcasso Reviewed-by: Jill R Reviewed-by: Abhijeet Kasurde (cherry picked from commit 8cc9397) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Mar 11, 2022
`ec2_vpc_igw`: fix NoneType error SUMMARY use paginator for describe internet gateways and add retry_codes='InvalidInternetGatewayID.NotFound' (thanks @alinabuzachis) Fixes ansible-collections#647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw ADDITIONAL INFORMATION previously added InternetGatewayAttached waiter but problem still persists (ansible-collections#691) Reviewed-by: Abhijeet Kasurde <None> Reviewed-by: Jill R <None> (cherry picked from commit 1965b05)
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Mar 11, 2022
`ec2_vpc_igw`: fix NoneType error SUMMARY use paginator for describe internet gateways and add retry_codes='InvalidInternetGatewayID.NotFound' (thanks @alinabuzachis) Fixes ansible-collections#647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw ADDITIONAL INFORMATION previously added InternetGatewayAttached waiter but problem still persists (ansible-collections#691) Reviewed-by: Abhijeet Kasurde <None> Reviewed-by: Jill R <None> (cherry picked from commit 1965b05)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 18, 2022
`ec2_vpc_igw`: fix NoneType error (#695) ec2_vpc_igw: fix NoneType error SUMMARY use paginator for describe internet gateways and add retry_codes='InvalidInternetGatewayID.NotFound' (thanks @alinabuzachis) Fixes #647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw ADDITIONAL INFORMATION previously added InternetGatewayAttached waiter but problem still persists (#691) Reviewed-by: Abhijeet Kasurde Reviewed-by: Jill R (cherry picked from commit 1965b05) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 18, 2022
`ec2_vpc_igw`: fix NoneType error (#695) ec2_vpc_igw: fix NoneType error SUMMARY use paginator for describe internet gateways and add retry_codes='InvalidInternetGatewayID.NotFound' (thanks @alinabuzachis) Fixes #647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw ADDITIONAL INFORMATION previously added InternetGatewayAttached waiter but problem still persists (#691) Reviewed-by: Abhijeet Kasurde Reviewed-by: Jill R (cherry picked from commit 1965b05) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
This issue/PR relates to a bug
community_review
mergeit
Merge the PR (SoftwareFactory)
module_utils
module_utils
module
module
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible/ansible-zuul-jobs#1368
SUMMARY
Add "InternetGatewayAttached" waiter
Fixes #647
ISSUE TYPE
COMPONENT NAME
ec2_vpc_igw