Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_vpc_igw: fix 'NoneType' object is not subscriptable #691

Conversation

jatorcasso
Copy link
Contributor

@jatorcasso jatorcasso commented Feb 24, 2022

Depends-On: ansible/ansible-zuul-jobs#1368

SUMMARY

Add "InternetGatewayAttached" waiter
Fixes #647

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_vpc_igw

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Feb 24, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@jatorcasso
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@ansibullbot ansibullbot added the module_utils module_utils label Feb 28, 2022
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on pathAll vs path, this lgmt now - thanks!

@jillr jillr added the mergeit Merge the PR (SoftwareFactory) label Feb 28, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@jatorcasso
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

This change depends on a change that failed to merge.

@goneri
Copy link
Member

goneri commented Feb 28, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@jatorcasso
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@jatorcasso
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 8cc9397 into ansible-collections:main Mar 1, 2022
@jatorcasso jatorcasso deleted the ec2_vpc_igw/fix_NoneType_error branch March 1, 2022 03:40
jatorcasso added a commit to jatorcasso/amazon.aws that referenced this pull request Mar 1, 2022
…ections#691)

ec2_vpc_igw: fix 'NoneType' object is not subscriptable

Depends-On: ansible/ansible-zuul-jobs#1368
SUMMARY
Add "InternetGatewayAttached" waiter
Fixes ansible-collections#647
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_vpc_igw

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
Reviewed-by: Abhijeet Kasurde <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 4, 2022
`ec2_vpc_igw`: fix NoneType error

SUMMARY

use paginator for describe internet gateways and add retry_codes='InvalidInternetGatewayID.NotFound' (thanks @alinabuzachis)
Fixes #647

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_vpc_igw
ADDITIONAL INFORMATION

previously added InternetGatewayAttached waiter but problem still persists (#691)

Reviewed-by: Abhijeet Kasurde <None>
Reviewed-by: Jill R <None>
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Mar 4, 2022
…ections#691)

ec2_vpc_igw: fix 'NoneType' object is not subscriptable

Depends-On: ansible/ansible-zuul-jobs#1368
SUMMARY
Add "InternetGatewayAttached" waiter
Fixes ansible-collections#647
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_vpc_igw

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
Reviewed-by: Abhijeet Kasurde <None>
(cherry picked from commit 8cc9397)
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Mar 4, 2022
…ections#691)

ec2_vpc_igw: fix 'NoneType' object is not subscriptable

Depends-On: ansible/ansible-zuul-jobs#1368
SUMMARY
Add "InternetGatewayAttached" waiter
Fixes ansible-collections#647
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_vpc_igw

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
Reviewed-by: Abhijeet Kasurde <None>
(cherry picked from commit 8cc9397)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 11, 2022
ec2_vpc_igw: fix 'NoneType' object is not subscriptable (#691)

Manual backport to stable-3: ec2_vpc_igw: fix 'NoneType' object is not subscriptable
SUMMARY
Add "InternetGatewayAttached" waiter
Fixes #647
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ec2_vpc_igw
Reviewed-by: Alina Buzachis 
Reviewed-by: Joseph Torcasso 
Reviewed-by: Jill R 
Reviewed-by: Abhijeet Kasurde 
(cherry picked from commit 8cc9397)
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 11, 2022
ec2_vpc_igw: fix 'NoneType' object is not subscriptable (#691)

Manual backport to stable-2: ec2_vpc_igw: fix 'NoneType' object is not subscriptable
SUMMARY
Add "InternetGatewayAttached" waiter
Fixes #647
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ec2_vpc_igw
Reviewed-by: Alina Buzachis 
Reviewed-by: Joseph Torcasso 
Reviewed-by: Jill R 
Reviewed-by: Abhijeet Kasurde 
(cherry picked from commit 8cc9397)
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Mar 11, 2022
`ec2_vpc_igw`: fix NoneType error

SUMMARY

use paginator for describe internet gateways and add retry_codes='InvalidInternetGatewayID.NotFound' (thanks @alinabuzachis)
Fixes ansible-collections#647

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_vpc_igw
ADDITIONAL INFORMATION

previously added InternetGatewayAttached waiter but problem still persists (ansible-collections#691)

Reviewed-by: Abhijeet Kasurde <None>
Reviewed-by: Jill R <None>
(cherry picked from commit 1965b05)
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Mar 11, 2022
`ec2_vpc_igw`: fix NoneType error

SUMMARY

use paginator for describe internet gateways and add retry_codes='InvalidInternetGatewayID.NotFound' (thanks @alinabuzachis)
Fixes ansible-collections#647

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_vpc_igw
ADDITIONAL INFORMATION

previously added InternetGatewayAttached waiter but problem still persists (ansible-collections#691)

Reviewed-by: Abhijeet Kasurde <None>
Reviewed-by: Jill R <None>
(cherry picked from commit 1965b05)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 18, 2022
`ec2_vpc_igw`: fix NoneType error (#695)

ec2_vpc_igw: fix NoneType error
SUMMARY
use paginator for describe internet gateways and add retry_codes='InvalidInternetGatewayID.NotFound' (thanks @alinabuzachis)
Fixes #647
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ec2_vpc_igw
ADDITIONAL INFORMATION
previously added InternetGatewayAttached waiter but problem still persists (#691)
Reviewed-by: Abhijeet Kasurde 
Reviewed-by: Jill R 
(cherry picked from commit 1965b05)
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 18, 2022
`ec2_vpc_igw`: fix NoneType error (#695)

ec2_vpc_igw: fix NoneType error
SUMMARY
use paginator for describe internet gateways and add retry_codes='InvalidInternetGatewayID.NotFound' (thanks @alinabuzachis)
Fixes #647
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ec2_vpc_igw
ADDITIONAL INFORMATION
previously added InternetGatewayAttached waiter but problem still persists (#691)
Reviewed-by: Abhijeet Kasurde 
Reviewed-by: Jill R 
(cherry picked from commit 1965b05)
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module_utils module_utils module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'NoneType' object is not subscriptable error in ec2_vpc_igw module
6 participants